GFM: be more clever on parsing fenced codeblock#369
Closed
tsl0922 wants to merge 1 commit into
Closed
Conversation
|
|
||
| FENCED_CODEBLOCK_START = /^[~`]{3,}/ | ||
| FENCED_CODEBLOCK_MATCH = /^(([~`]){3,})\s*?((\S+?)(?:\?\S*)?)?\s*?\n(.*?)^\1\2*\s*?\n/m | ||
| FENCED_CODEBLOCK_START = /^\s*?[~`]{3,}/ |
Owner
There was a problem hiding this comment.
\s*? is not correct since after testing I found that only a maximum of three spaces is allowed by GFM on Github.
Contributor
Author
There was a problem hiding this comment.
Yes, it can be more strictly here, changed to [ ]{,3}. More than 3 spaces will be identified as normal code block at github, so does kramdown.
Contributor
Author
There was a problem hiding this comment.
[ ]{,3} failed travis test for 1.8.7, changed it to [ ]{0,3}
a4083cb to
3d7293e
Compare
3d7293e to
2dc33d5
Compare
Owner
|
Thanks for the changes - this looks good to me now! I will include it for the next release. |
Owner
|
Thanks for the pull request - will be in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds support for fenced code block with whitespace before the ```
source:
github result:
kramdown result: