Skip to content

Allow using tab as separator in table - #370

Closed
tsl0922 wants to merge 1 commit into
gettalong:masterfrom
tsl0922:table
Closed

Allow using tab as separator in table#370
tsl0922 wants to merge 1 commit into
gettalong:masterfrom
tsl0922:table

Conversation

@tsl0922

@tsl0922 tsl0922 commented Sep 8, 2016

Copy link
Copy Markdown
Contributor

source:

right | center
---:    |   :---:
cell1 | cell2
cell3 | cell4

expect:

right center
cell1 cell2
cell3 cell4

actual:

<table>
  <tbody>
    <tr>
      <td>right</td>
      <td>center</td>
    </tr>
    <tr>
      <td>—:</td>
      <td>:—:</td>
    </tr>
    <tr>
      <td>cell1</td>
      <td>cell2</td>
    </tr>
    <tr>
      <td>cell3</td>
      <td>cell4</td>
    </tr>
  </tbody>
</table>

I'm using the GFM parser, but fix this in the GFM parser requires a lot of change, so the changes are made to the kramdown parser. Since this this a new feature, it may not affect the existing docs.

@gettalong gettalong self-assigned this Sep 9, 2016
@gettalong

Copy link
Copy Markdown
Owner

Thanks for the pull request!

This is not a bug fix but a feature enhancement and it can potentially impact existing documents. Therefore I would normally postpone this to the 2.0 release of kramdown.

However, this change will probably not affect many existing documents - I will have to think about it a bit more.

@gettalong

Copy link
Copy Markdown
Owner

Thanks again for the pull request - this will be in the next release.

@gettalong gettalong closed this Nov 13, 2016
@tsl0922
tsl0922 deleted the table branch June 2, 2017 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants