Skip to content

Allow for passing Rouge formatter as a String - #448

Closed
kejadlen wants to merge 1 commit into
gettalong:masterfrom
kejadlen:rouge-formatter
Closed

Allow for passing Rouge formatter as a String#448
kejadlen wants to merge 1 commit into
gettalong:masterfrom
kejadlen:rouge-formatter

Conversation

@kejadlen

Copy link
Copy Markdown
Contributor

I thought this might be handy so that Jekyll users can change the Rouge formatter.

@gettalong gettalong self-assigned this Sep 25, 2017
@gettalong

Copy link
Copy Markdown
Owner

Thanks for your pull request but I'm not really convinced that this is a good change... will have to think about it.

@kejadlen

Copy link
Copy Markdown
Contributor Author

Yeah, I can see that - do you suppose the String to Class transform might make more sense in Jekyll than Kramdown? I'm not too familiar with either project, so don't know what's reasonable.

@gettalong

Copy link
Copy Markdown
Owner

@kejadlen Thanks for your pull request! After some consideration, I have changed your pull request a bit (remove unnecessary changes, changed String to a more restricted regex) and included it.

I.e. this will be in the next release.

@gettalong gettalong closed this Nov 26, 2017
@kejadlen

Copy link
Copy Markdown
Contributor Author

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants