Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for passing Rouge formatter as a String #448

Closed
wants to merge 1 commit into from
Closed

Allow for passing Rouge formatter as a String #448

wants to merge 1 commit into from

Conversation

@kejadlen
Copy link
Contributor

@kejadlen kejadlen commented Sep 11, 2017

I thought this might be handy so that Jekyll users can change the Rouge formatter.

@gettalong gettalong self-assigned this Sep 25, 2017
@gettalong
Copy link
Owner

@gettalong gettalong commented Sep 25, 2017

Thanks for your pull request but I'm not really convinced that this is a good change... will have to think about it.

@kejadlen
Copy link
Contributor Author

@kejadlen kejadlen commented Sep 26, 2017

Yeah, I can see that - do you suppose the String to Class transform might make more sense in Jekyll than Kramdown? I'm not too familiar with either project, so don't know what's reasonable.

@gettalong
Copy link
Owner

@gettalong gettalong commented Nov 26, 2017

@kejadlen Thanks for your pull request! After some consideration, I have changed your pull request a bit (remove unnecessary changes, changed String to a more restricted regex) and included it.

I.e. this will be in the next release.

@gettalong gettalong closed this Nov 26, 2017
@kejadlen
Copy link
Contributor Author

@kejadlen kejadlen commented Nov 26, 2017

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants