Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly convert img tags without a src attribute #470

Closed
wants to merge 2 commits into from

Conversation

@donv
Copy link
Contributor

@donv donv commented Nov 13, 2017

img tags without a src attribute would give an "undefined method `empty?' for nil:NilClass" exception.

donv added 2 commits Nov 13, 2017
`img` tags without a `src` attribute would give an "undefined method `empty?' for nil:NilClass" exception.
@gettalong gettalong self-assigned this Nov 26, 2017
@gettalong
Copy link
Owner

@gettalong gettalong commented Nov 26, 2017

Thank you for your contribution! I have squashed your commits and included them for the next release.

@gettalong gettalong closed this Nov 26, 2017
@donv donv deleted the donv:patch-1 branch Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants