New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-deprecated SCSS color function. #485

Merged
merged 1 commit into from Feb 3, 2018

Conversation

Projects
None yet
2 participants
@ccorn
Contributor

ccorn commented Jan 8, 2018

This PR is to remove the following warning by rake doc:

DEPRECATION WARNING on line 166 of /_design.scss:
The operation `#1666A3 div 2` is deprecated and will be an error in future versions.
Consider using Sass's color functions instead.
http://sass-lang.com/documentation/Sass/Script/Functions.html#other_color_functions

My first attempt was to use darken($link-color, 50%) and that was wrong because apparently equivalent to adjust-color($link-color, $lightness: -50%), resulting in black. The original intent is equivalent to scale-color($link-color, $lightness: -50%) so I have used that.

Verified that the resulting CSS is the same as in the master branch.

@ccorn ccorn force-pushed the ccorn:scss-color branch from 79f21e2 to 762e7c1 Jan 25, 2018

@gettalong gettalong self-assigned this Feb 3, 2018

@gettalong gettalong merged commit 762e7c1 into gettalong:master Feb 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gettalong

This comment has been minimized.

Owner

gettalong commented Feb 3, 2018

Thanks!

@ccorn ccorn deleted the ccorn:scss-color branch Feb 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment