Skip to content

Use non-deprecated SCSS color function. - #485

Merged
gettalong merged 1 commit into
gettalong:masterfrom
ccorn:scss-color
Feb 3, 2018
Merged

Use non-deprecated SCSS color function.#485
gettalong merged 1 commit into
gettalong:masterfrom
ccorn:scss-color

Conversation

@ccorn

@ccorn ccorn commented Jan 8, 2018

Copy link
Copy Markdown
Contributor

This PR is to remove the following warning by rake doc:

DEPRECATION WARNING on line 166 of /_design.scss:
The operation `#1666A3 div 2` is deprecated and will be an error in future versions.
Consider using Sass's color functions instead.
http://sass-lang.com/documentation/Sass/Script/Functions.html#other_color_functions

My first attempt was to use darken($link-color, 50%) and that was wrong because apparently equivalent to adjust-color($link-color, $lightness: -50%), resulting in black. The original intent is equivalent to scale-color($link-color, $lightness: -50%) so I have used that.

Verified that the resulting CSS is the same as in the master branch.

@gettalong gettalong self-assigned this Feb 3, 2018
@gettalong
gettalong merged commit 762e7c1 into gettalong:master Feb 3, 2018
@gettalong

Copy link
Copy Markdown
Owner

Thanks!

@ccorn
ccorn deleted the scss-color branch February 4, 2018 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants