Skip to content

Upgrade CI's node version to avoid mathjax-node errors - #498

Merged
gettalong merged 1 commit into
gettalong:masterfrom
ccorn:node60
Mar 4, 2018
Merged

gettalong merged 1 commit into
gettalong:masterfrom
ccorn:node60

Conversation

@ccorn

@ccorn ccorn commented Mar 3, 2018

Copy link
Copy Markdown
Contributor

mathjax-node now seems to require node >= 6.0.0 (check the CI errors on #482).

@ccorn

ccorn commented Mar 3, 2018

Copy link
Copy Markdown
Contributor Author

Hmm, have to update test Mathjax outputs as well. I'd like to introduce a Rakefile target dev:update_mathjax_node_tests for that, as has been done for SsKaTeX and KaTeX.

... in order to match current mathjax-node-cli deps and outputs.
@ccorn

ccorn commented Mar 3, 2018 •

Copy link
Copy Markdown
Contributor Author

Made a minimal patch without additions to Rakefile (which could be subject of a separate PR).

@gettalong gettalong self-assigned this Mar 4, 2018
@gettalong
gettalong merged commit a782174 into gettalong:master Mar 4, 2018
@gettalong

Copy link
Copy Markdown
Owner

Thanks!

@ccorn
ccorn deleted the node60 branch March 4, 2018 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants