Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CI's node version to avoid mathjax-node errors #498

Merged
merged 1 commit into from Mar 4, 2018

Conversation

@ccorn
Copy link
Contributor

@ccorn ccorn commented Mar 3, 2018

mathjax-node now seems to require node >= 6.0.0 (check the CI errors on #482).

@ccorn
Copy link
Contributor Author

@ccorn ccorn commented Mar 3, 2018

Hmm, have to update test Mathjax outputs as well. I'd like to introduce a Rakefile target dev:update_mathjax_node_tests for that, as has been done for SsKaTeX and KaTeX.

... in order to match current mathjax-node-cli deps and outputs.
@ccorn ccorn force-pushed the ccorn:node60 branch from 60fadc6 to a782174 Mar 3, 2018
@ccorn
Copy link
Contributor Author

@ccorn ccorn commented Mar 3, 2018

Made a minimal patch without additions to Rakefile (which could be subject of a separate PR).

@gettalong gettalong self-assigned this Mar 4, 2018
@gettalong gettalong merged commit a782174 into gettalong:master Mar 4, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gettalong
Copy link
Owner

@gettalong gettalong commented Mar 4, 2018

Thanks!

@ccorn ccorn deleted the ccorn:node60 branch Mar 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants