Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more auto-generated files to .gitignore #518

Closed
wants to merge 3 commits into from

Conversation

@glebm
Copy link
Contributor

@glebm glebm commented May 24, 2018

No description provided.

.gitignore Outdated
kramdown.gemspec
man/man1/kramdown.1
node_modules/
package-lock.json

This comment has been minimized.

@gettalong

gettalong May 24, 2018
Owner

Lines 4, 9 and 10 have nothing to do with kramdown, please remove them. The other changes are fine.

This comment has been minimized.

@glebm

glebm May 25, 2018
Author Contributor

Removed line 4.
Line 9 and 10 are for npm install:

- npm install mathjax-node-cli cssstyle

This comment has been minimized.

@gettalong

gettalong May 25, 2018
Owner

That may be so but that line is from Travis and this is nothing that is generated by kramdown. As with .bundle, node_modules is something that the user decides, so it shouldn't be in the .gitignore file.

This comment has been minimized.

@glebm

glebm May 26, 2018
Author Contributor

Done, though I disagree because this is the standard way of installing node dependencie.

glebm added 2 commits May 25, 2018
@gettalong
Copy link
Owner

@gettalong gettalong commented May 26, 2018

Merged

@gettalong gettalong closed this May 26, 2018
@junaruga junaruga mentioned this pull request Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants