Conversation
gettalong
reviewed
May 24, 2018
| kramdown.gemspec | ||
| man/man1/kramdown.1 | ||
| node_modules/ | ||
| package-lock.json |
Owner
There was a problem hiding this comment.
Lines 4, 9 and 10 have nothing to do with kramdown, please remove them. The other changes are fine.
Contributor
Author
There was a problem hiding this comment.
Removed line 4.
Line 9 and 10 are for npm install:
Line 30 in 55d4072
Owner
There was a problem hiding this comment.
That may be so but that line is from Travis and this is nothing that is generated by kramdown. As with .bundle, node_modules is something that the user decides, so it shouldn't be in the .gitignore file.
Contributor
Author
There was a problem hiding this comment.
Done, though I disagree because this is the standard way of installing node dependencie.
Owner
|
Merged |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.