Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Rouge plaintext lexer with :guess_lang opt #573

Merged
merged 2 commits into from Jan 23, 2019
Merged

Enable Rouge plaintext lexer with :guess_lang opt #573

merged 2 commits into from Jan 23, 2019

Conversation

ashmaroli
Copy link
Contributor

Utilize :guess_lang highlighter-option from kramdown-2.0 to enable Rouge's plaintext lexer
(This avoids having to maintain multiple options for same result)

Resolves #572

@gettalong gettalong self-requested a review January 23, 2019 18:56
@gettalong gettalong self-assigned this Jan 23, 2019
gettalong
gettalong requested changes Jan 23, 2019
View reviewed changes
Copy link
Owner

@gettalong gettalong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this pull request - I actually had the same 20 minutes ago 😄

lib/kramdown/converter/syntax_highlighter/rouge.rb Outdated Show resolved Hide resolved
@ashmaroli
Copy link
Contributor Author

I actually had the same 20 minutes ago

Thanks for the compliment. Feels awesome to know that I'm close to your skill level 😉 😃

@gettalong gettalong merged commit 0dca254 into gettalong:master Jan 23, 2019
@ashmaroli ashmaroli deleted the enable-css-class branch January 24, 2019 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gettalong gettalong gettalong approved these changes

Assignees

@gettalong gettalong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashmaroli @gettalong