Use constants to return valid smart-quotes values #600
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is helpful for downstream libraries such as Jekyll where a single configuration is used to process numerous kramdown documents.
To illustrate, consider the following flow:
By running the above script, there's going to be a 1000 instances of
Kramdown::Document
(obviously).But each of those instance is going to use the same set of
options
.However, each of those instance is going to allocate a new
%w[lsquo rsquo ldquo rdquo]
viaval.split(/,/)
during the validation. The arrays so obtained are valid but in spite of that, each constituent element is consequently forced to initialize anArgumentError
viaKernel#Integer
and then fallback to returning original element.Attn: @gettalong
P.S. Additionally, the
else
block could be optimized to not rescue an intermediate exception, but I chose to defer that for future.