Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpolate stateless regexps just once #601

Merged

Conversation

ashmaroli
Copy link
Contributor

@ashmaroli ashmaroli commented May 15, 2019

If an interpolated regular expression within a method definition and if the interpolation doesn't depend on the state of the instance, then they should essentially be interpolated just once to avoid multiple allocations and every call to the associated method.

@gettalong gettalong self-assigned this May 15, 2019
@gettalong gettalong merged commit 41d20e1 into gettalong:master May 15, 2019
@gettalong
Copy link
Owner

@gettalong gettalong commented May 15, 2019

Thanks for your contribution - I have merged the changes!

@ashmaroli ashmaroli deleted the interpolate-stateless-regexps-once branch May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants