Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated footnotes #63

Closed
wants to merge 4 commits into from
Closed

Conversation

@powerpak
Copy link
Contributor

@powerpak powerpak commented Jun 20, 2013

Implements issue #62

@ghost ghost assigned gettalong Jun 20, 2013
@gettalong
Copy link
Owner

@gettalong gettalong commented Jun 20, 2013

Thanks! I have had a quick look at the code and it looks good. One issue that I have identified is that the ID values are now duplicated for the <sup> elements.

@powerpak
Copy link
Contributor Author

@powerpak powerpak commented Jun 20, 2013

Good point, that's obviously invalid HTML. Should be fixed in the last push.

@gettalong
Copy link
Owner

@gettalong gettalong commented Jul 1, 2013

Thanks for the pull request! I added the generation of the backlinks to all footnote markers.

Additionally I changed the format of the repeated IDs to use colons instead of dashes because this could potentially lead to duplicate IDs.

@gettalong gettalong closed this Jul 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants