Repeated footnotes#63
Closed
powerpak wants to merge 4 commits into
Closed
Conversation
ghost
assigned
Owner
|
Thanks! I have had a quick look at the code and it looks good. One issue that I have identified is that the ID values are now duplicated for the |
…crementing a repeat counter
Contributor
Author
|
Good point, that's obviously invalid HTML. Should be fixed in the last push. |
Owner
|
Thanks for the pull request! I added the generation of the backlinks to all footnote markers. Additionally I changed the format of the repeated IDs to use colons instead of dashes because this could potentially lead to duplicate IDs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements issue #62