Use private constants to define :toc_levels option#641
Merged
gettalong merged 1 commit intogettalong:masterfrom Feb 22, 2020
Merged
Use private constants to define :toc_levels option#641gettalong merged 1 commit intogettalong:masterfrom
gettalong merged 1 commit intogettalong:masterfrom
Conversation
Owner
|
Thank you! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is to reduce array allocation when multiple
Kramdown::Documentobjects are initialized with the same:toc_levelsvalue.Summary
When
Kramdown::Documentis initialized with option:toc_levels => [1, 2, 3, 4, 5, 6]use a predefined constant with identical contents instead of generating a new array from the option value or whenKramdown::Documentis initialized with option:toc_levels => (1..6), use a predefined constant array instead of converting the range into a new Array.It is safe to use constant values because the (merged)
optionsattribute ofKramdown::Documentinstances is already frozen on initialization.