Optimize preparation of options for Rouge #655
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
[span_opts, block_opts]
for every method call with serial calls to an extracted module method.Hash#update
and a static{:wrap=>false}
with a direct mutation viaHash#[]=
to avoid allocating{:wrap=>false}
on every method call.hash.keys
allocates an array even for empty hashes, add a guard-clause.Benchmark
(on Ruby 2.4, Windows)
Memory profiles