Don't add newline after a nested list#680
Closed
Convincible wants to merge 2 commits intogettalong:masterfrom
Convincible:patch-2
Closed
Don't add newline after a nested list#680Convincible wants to merge 2 commits intogettalong:masterfrom Convincible:patch-2
Convincible wants to merge 2 commits intogettalong:masterfrom
Convincible:patch-2
Conversation
Element opts hash carrying info about the parent is generally useful. Immediate use case is simple fix for a bug where nested lists don't realise they are nested, and hence newlines are added after the end of a nested list (within the main list) when this is of course unnecessary and can cause rendering issues.
Contributor
Author
|
Now properly using the |
Owner
|
Thank you - I will have a more in-depth look later! |
Contributor
Author
|
Has this bug been fixed @gettalong ? |
Owner
|
@Convincible No, this change is not yet included but looks good! Please add some test and then it is good to go - thanks! |
Contributor
Where would such a test go? |
Owner
|
Thanks! I have added a test case and this will be in the next release. @cabo FYI Next release within a week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks whether element is a list, and if that list is nested within another list (i.e. the list's parent is a list item). In this case we should not add another newline.
The change results in nested lists appearing as:
rather than: