fix: fix LaTeX entity conversion group location #681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This correctly places the `{}` group after the LaTeX commands used for
conversion, rather than before. It appears this has been broken since
edbd1fd.
Also updates the span/text_substitutions/entities test to include
`<span>`, which will be converted by the old converter to
`{}\textlessspan{}\textgreater`, which should instead be
`\textless{}span\textgreater{}`. The former will fail to compile, and should
throw an error.
|
Thanks for the pull request! Just fyi: The commit you mentioned is not the one that introduced the bug but this one is. |
|
Thanks for your contribution, this will be in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This correctly places the
{}group after the LaTeX commands used for conversion, rather than before. It appears this has been broken since edbd1fd.Also updates the span/text_substitutions/entities test to include
<span>, which will be converted by the old converter to{}\textlessspan{}\textgreater, which should instead be\textless{}span\textgreater{}. The former will fail to compile, and should throw an error.