Skip to content

Bugfix: th and td elements can be empty#682

Closed
Convincible wants to merge 1 commit intogettalong:masterfrom
Convincible:patch-3
Closed

Bugfix: th and td elements can be empty#682
Convincible wants to merge 1 commit intogettalong:masterfrom
Convincible:patch-3

Conversation

@Convincible
Copy link
Contributor

It is possible and valid to have an empty <td></td> element (similarly with <th>) and would be invalid to close it as <td />.

This change adds th and td to the list of elements that must be explicitly closed even if they have no content.

It avoids a bug where the invalid output <td /> will be generated if a table cell has no content.

@gettalong
Copy link
Owner

Thanks for your contribution! Could you please add a test case in test/testcases/block/14_table?

@gettalong gettalong self-assigned this Dec 28, 2020
@gettalong
Copy link
Owner

Thanks for opening this issue - I have fixed this for the next release.

@gettalong gettalong closed this Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants