New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better default HTML template #73

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@lydell
Contributor

lydell commented Aug 12, 2013

Added doctype and charset.

Better default HTML template
Added doctype and charset.

@ghost ghost assigned gettalong Aug 13, 2013

@gettalong

This comment has been minimized.

Owner

gettalong commented Aug 13, 2013

Thanks for the pull request. Setting the doctype is okay but setting the encoding in this way isn't because it might not be UTF-8. The root.options[:encoding] value is available under 1.9/2.0 which holds the used encoding.

@lydell

This comment has been minimized.

Contributor

lydell commented Aug 13, 2013

I think that UTF-8 is better than no charset defined. Do you propose <meta charset="<%= root.options[:encoding] %>">?

@gettalong

This comment has been minimized.

Owner

gettalong commented Aug 21, 2013

Yes, if <meta charset="<%= @converter.root.options[:encoding] %>"> is used this should work fine.

@gettalong

This comment has been minimized.

Owner

gettalong commented Aug 21, 2013

Fixed in commit 6dac5b1

@gettalong gettalong closed this Aug 21, 2013

@lydell

This comment has been minimized.

Contributor

lydell commented Aug 22, 2013

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment