Skip to content

Better default HTML template - #73

Closed
lydell wants to merge 1 commit into
gettalong:masterfrom
lydell:master
Closed

lydell wants to merge 1 commit into
gettalong:masterfrom
lydell:master

Conversation

@lydell

@lydell lydell commented Aug 12, 2013

Copy link
Copy Markdown
Contributor

Added doctype and charset.

Added doctype and charset.
@ghost ghost assigned gettalong Aug 13, 2013
@gettalong

Copy link
Copy Markdown
Owner

Thanks for the pull request. Setting the doctype is okay but setting the encoding in this way isn't because it might not be UTF-8. The root.options[:encoding] value is available under 1.9/2.0 which holds the used encoding.

@lydell

lydell commented Aug 13, 2013

Copy link
Copy Markdown
Contributor Author

I think that UTF-8 is better than no charset defined. Do you propose <meta charset="<%= root.options[:encoding] %>">?

@gettalong

Copy link
Copy Markdown
Owner

Yes, if <meta charset="<%= @converter.root.options[:encoding] %>"> is used this should work fine.

@gettalong

Copy link
Copy Markdown
Owner

Fixed in commit 6dac5b1

@gettalong gettalong closed this Aug 21, 2013
@lydell

lydell commented Aug 22, 2013

Copy link
Copy Markdown
Contributor Author

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants