Better default HTML template #73

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@lydell
lydell commented Aug 12, 2013

Added doctype and charset.

@lydell lydell Better default HTML template
Added doctype and charset.
d48e221
@gettalong gettalong was assigned Aug 13, 2013
@gettalong
Owner

Thanks for the pull request. Setting the doctype is okay but setting the encoding in this way isn't because it might not be UTF-8. The root.options[:encoding] value is available under 1.9/2.0 which holds the used encoding.

@lydell
lydell commented Aug 13, 2013

I think that UTF-8 is better than no charset defined. Do you propose <meta charset="<%= root.options[:encoding] %>">?

@gettalong
Owner

Yes, if <meta charset="<%= @converter.root.options[:encoding] %>"> is used this should work fine.

@gettalong
Owner

Fixed in commit 6dac5b1

@gettalong gettalong closed this Aug 21, 2013
@lydell
lydell commented Aug 22, 2013

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment