Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make initial list label available for processor #740

Closed

Conversation

cabo
Copy link
Contributor

@cabo cabo commented Dec 9, 2021

Making the initial list label available to the processor enables implementing behaviors such as deriving a starting number from the initial label.
(This should not impact any existing code.)

@cabo cabo changed the title Make initial list label available for processor. Make initial list label available for processor Dec 9, 2021
@gettalong
Copy link
Owner

Thanks!

  • Yes, this will not impact any code or the output, so 👍

  • As for semantics: Would it be better to call it item_label and assign it to all items? Then the list label can be determined by looking at the first item label.

@gettalong gettalong self-assigned this Dec 10, 2021
@cabo
Copy link
Contributor Author

cabo commented Dec 10, 2021

I specifically need the first label of the list (so I put it on the list).
But putting a label on each item would only insignificantly increase the amount of code needed.

@gettalong
Copy link
Owner

Hmm... okay, then we will only use the first one and if need be add the change for the others.

One thing to change, though: Could you name it :first_list_marker? In the syntax documentation it is always called "list marker" and since it is the first one and not something else, it should also have "first" somewhere in its name.

@cabo cabo force-pushed the make-initial-list-label-available branch from 6869a77 to fc6bd2b Compare December 10, 2021 14:26
@cabo
Copy link
Contributor Author

cabo commented Dec 10, 2021

I pushed an update with :first_list_marker.

@gettalong
Copy link
Owner

Thanks for the changes - I will do a release for this in the near future.

cabo added a commit to cabo/kramdown that referenced this pull request Mar 12, 2022
Similar to PR gettalong#740:

Making the codespan delimiter available to the processor enables
implementing behaviors deriving variant behavior from using different
numbers of delimiters.
(This should not impact any existing code.)
@gettalong
Copy link
Owner

Thanks - I have cherry-picked the commit!

@gettalong gettalong closed this Mar 13, 2022
gettalong pushed a commit that referenced this pull request Mar 18, 2022
Similar to PR #740:

Making the codespan delimiter available to the processor enables
implementing behaviors deriving variant behavior from using different
numbers of delimiters.
(This should not impact any existing code.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants