Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon and query are not saved after restart when modifying a Saved Search #1048

Open
kocio-pl opened this issue Mar 4, 2024 · 3 comments
Open
Labels
bug reproducible-in-git Issues that affect the current dev version

Comments

@kocio-pl
Copy link
Contributor

kocio-pl commented Mar 4, 2024

Editing saved searches does not fully survive app restart - name is altered as expected, but icon and query stay the same.

@nekohayo nekohayo changed the title Search editor problems Icon and query are not saved after restart when modifying a Saved Search Mar 4, 2024
@nekohayo
Copy link
Member

nekohayo commented Mar 4, 2024

As a general note: please be more specific with your issue titles in the future ;)

@kocio-pl
Copy link
Contributor Author

kocio-pl commented Mar 4, 2024

I understand the importance of being specific with issue tickets, but in the current state I find it hard to properly describe what kind of problem is it. Moreover when digging, I sometimes find more problems which I'm not sure should be reported separately or not.

@nekohayo
Copy link
Member

nekohayo commented Mar 10, 2024

There seems to be a bit of a contradiction between the UI and the backend here, because in the backend's savedSearches.py we can see that the query seems to be a read-only "property", if the comment is to be believed:

    @GObject.Property(type=str)
    def query(self) -> str:
        """Read only property."""

        return self._query

… though it does have a setter method just below that…

    @query.setter
    def set_query(self, value: str) -> None:
        self._query = value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug reproducible-in-git Issues that affect the current dev version
Projects
None yet
Development

No branches or pull requests

2 participants