Don't loop forever with invalid quick add date#749
Merged
diegogangl merged 1 commit intogetting-things-gnome:masterfrom Jan 8, 2022
Merged
Don't loop forever with invalid quick add date#749diegogangl merged 1 commit intogetting-things-gnome:masterfrom
diegogangl merged 1 commit intogetting-things-gnome:masterfrom
Conversation
Quick entering "Do a thing due:meh" causes GTG to completely freeze, and need to be killed. This fixes it to treat tokens with invalid dates the as other invalid tokens, ignoring them (and removing them from the input text). This issue was caused since the the `continue` in the parsing loop didn't remove the token, causing it to loop forever on the invalid token.
Neui
approved these changes
Jan 8, 2022
Contributor
Neui
left a comment
Neui
left a comment
There was a problem hiding this comment.
Was able to reproduce the issue and this fixed the issue. Test seems also work (just hangs, which hopefully would indicate something is wrong).
diegogangl
approved these changes
Jan 8, 2022
Contributor
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick entering
Do a thing due:mehcauses GTG to completely freeze, and need to be killed. This fixes it to treat tokens with invalid dates the as other invalid tokens, ignoring them (and removing them from the input text).This issue was caused since the the
continuein the parsing loop didn't remove the token, causing it to loop forever on the invalid token.