From 0946eebd82a56dfa0e3a7292b7e97b8f07b2c465 Mon Sep 17 00:00:00 2001 From: Tali Petrover Date: Tue, 30 May 2023 12:13:38 +0300 Subject: [PATCH 1/3] add min clip length to search params in video creative search --- lib/searchvideoscreative.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/searchvideoscreative.js b/lib/searchvideoscreative.js index fb56a99..c05d477 100644 --- a/lib/searchvideoscreative.js +++ b/lib/searchvideoscreative.js @@ -22,6 +22,7 @@ class SearchVideosCreative extends GettyApiRequest { this.productTypes = []; this.sortOrder = null; this.headers = {}; + this.minClipLength = 0; } execute() { @@ -40,6 +41,7 @@ class SearchVideosCreative extends GettyApiRequest { addParameter(params, "phrase", this.phrase); addParameter(params, "product_types", this.productTypes); addParameter(params, "sort_order", this.sortOrder); + super.addParameter("min_clip_length", this.minClipLength); var path = "/v3/search/videos/creative"; var query = querystring.stringify(params); @@ -124,7 +126,10 @@ class SearchVideosCreative extends GettyApiRequest { return this; } - + withMinClipLength(minLengthInSeconds) { + this.minClipLength = minLengthInSeconds; + return this; + } } function addParameter(params, key, value) { From b27ee747b3798e764195d405e0333b631f149d06 Mon Sep 17 00:00:00 2001 From: Tali Petrover Date: Tue, 30 May 2023 12:14:12 +0300 Subject: [PATCH 2/3] add test --- tests/searchvideoscreativetests.js | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tests/searchvideoscreativetests.js b/tests/searchvideoscreativetests.js index ead9dd1..742ad97 100644 --- a/tests/searchvideoscreativetests.js +++ b/tests/searchvideoscreativetests.js @@ -56,7 +56,10 @@ test.beforeEach(t=>{ .query({"phrase":"monkey"}) .reply(200,function(path, reqBody, cb) { cb(null,[200, {response: "response", headers: this.req.headers}]); - }); + }) + .get("/v3/search/videos/creative") + .query({ "min_clip_length": "15", "phrase": "cat" }) + .reply(200, {response : "min_clip_length"}); }); test("SearchVideosCreative: withPhrase will include phrase in query", t => { @@ -168,3 +171,9 @@ test ("SearchVideosCreative: withAcceptLanguage will include the Accept-Language t.is(body.response,"response"); })); }); + +test("SearchVideosCreative: withMinClipLength will include min_clip_length in query", async t => { + var client = new api({ apiKey: "apikey", apiSecret: "apisecret" }, null); + const res = await client.searchvideoscreative().withMinClipLength(15).withPhrase("cat").execute(); + t.is(res.response, "min_clip_length"); +}); \ No newline at end of file From cd0eb624e50212ee9462c712aab31a35755e2c34 Mon Sep 17 00:00:00 2001 From: Tali Petrover Date: Tue, 30 May 2023 13:44:04 +0300 Subject: [PATCH 3/3] eslint --- lib/searchvideoscreative.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/searchvideoscreative.js b/lib/searchvideoscreative.js index a9611a5..0fe5ffb 100644 --- a/lib/searchvideoscreative.js +++ b/lib/searchvideoscreative.js @@ -43,7 +43,7 @@ class SearchVideosCreative extends GettyApiRequest { super.addParameter("product_types", this.productTypes); super.addParameter("safe_search", this.safeSearch); super.addParameter("sort_order", this.sortOrder); - super.addParameter("min_clip_length", this.minClipLength); + super.addParameter("min_clip_length", this.minClipLength); var path = "/v3/search/videos/creative"; var query = querystring.stringify(this.params);