Add mempool app #470

bguillaumat · 2021-01-29T14:37:23Z

App Submission

App name

Mempool Space

Version

2.1.1

One line description of the app

(max 50 characters)

A mempool visualizer, explorer and fee estimator

Summary of the app

(50 to 200 words)

Mempool is the official self-hosted version of the fully featured explorer, visualizer, fee estimator, and API service running on mempool.space, an open source project developed and operated for the benefit of the Bitcoin community, with a focus on the emerging transaction fee market to help our transition into a multi-layer ecosystem.

Developed by

mempool.space

Developer website

https://mempool.space/about

Source code repository

https://github.com/mempool/mempool

Support link

(Link to your Telegram support channel, GitHub issues/discussions, support portal, or any other place where users could contact you for support.)

https://t.me/mempoolspace

Uses

Bitcoin Core
Electrum server
LND

256x256 SVG icon

(GitHub doesn't allow uploadig SVGs directly. Upload your file to an alternate service, like https://svgur.com, and paste the link below.)

App screenshots

(Upload 3 to 5 high-quality screenshots (at least 1280x800px) of your app in PNG format.)

I have tested my app on:

resolve #452

louneskmt · 2021-01-29T16:07:57Z

Where can we find your source code (Dockerfiles, etc)?

bguillaumat · 2021-01-29T16:13:40Z

@louneskmt I've forked the main repo, but I'm actually doing a "clean" way to do it so we can work with all the new releases I'll send you the link when I've finished ;)

louneskmt · 2021-01-29T16:55:34Z

apps/mempool/docker-compose.yml

+    tag: "umbrel-app {{.Name}}"
+
+services:
+  app:


Should be named web to keep consistency with other apps.

Fixed 9d61783

louneskmt · 2021-01-29T16:57:37Z

apps/mempool/docker-compose.yml

+  db:
+    image: bguillaumat/mempool-db:v2.0.1
+    logging: *default-logging
+    restart: on-failure
+    stop_grace_period: 1m
+    volumes:
+      - ${APP_DATA_DIR}/mysql:/var/lib/mysql
+    environment:
+      MYSQL_USER: "mempool"
+      MYSQL_PASSWORD: "mempool"
+    expose:
+     - "3306"
+    networks:
+       default:
+         ipv4_address: $APP_MEMPOOL_DB_IP


It may be better to directly use official MariaDB/mysql images here (see Luke's review and b444272 as I did exactly this today).

Hum I guess it can be better but since my other repo split every files and format them so we can easily track mempool updates it's will be a "lost of time" to copy the files here every time we update the app.
If you really think we needs to put it here I will 😃

Yeah, thinking about this more, it's fine if you guys wanna do it like this.

I'm thinking ahead about how app developers will want to package apps when the Umbrel app configuration lives in the app's own repo. It makes sense in that case because they will probably already have an existing Docker image, so they don't want to create and maintain yet another child Dockerfile specifically for Umbrel, it's handy if they can use oll their existing Docker images (or official images) and then just pass in some Umbrel specific init scripts.

But that's not how things work right now, and you guys are already having to create your own Docker images for many projects, so I guess there's no issue with you including whatever you want directly in the image. It also means you can edit and maintain them all in one place.

So it's fine to keep doing it like this. (sorry Lounes! feel free to undo your changes if you want.)

It won't make sense in the future but it's fine to do it like this now.

louneskmt · 2021-01-29T16:59:05Z

apps/mempool/docker-compose.yml

+    expose:
+      - "8999"


See Luke's comment: #461 (comment)

(I know we both did the same mistakes the same day haha)

Fixed 9d61783acfe635971bc213ebcfdfe04d4f4d0233

bguillaumat · 2021-01-29T17:01:29Z

Here it is https://github.com/bguillaumat/umbrel-mempool

louneskmt · 2021-01-29T18:11:49Z

Also, if you want this PR to automatically close the linked issue, you need to change resolve (#452) to Closes #452 or Resolves #452.

lukechilds · 2021-01-30T08:22:37Z

I'm seeing these logs on first boot:

api_1  | Jan 30 08:21:36 [95] ERR: $list24h() errorExpression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'mempool.statistics.id' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by
api_1  | Jan 30 08:21:36 [95] ERR: $list1W() errorError: Expression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'mempool.statistics.id' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by
api_1  | Jan 30 08:21:36 [95] ERR: $list1M() errorError: Expression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'mempool.statistics.id' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by
api_1  | Jan 30 08:21:36 [95] ERR: $list3M() errorError: Expression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'mempool.statistics.id' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by
api_1  | Jan 30 08:21:36 [95] ERR: $list6M() errorError: Expression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'mempool.statistics.id' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by
api_1  | Jan 30 08:21:36 [95] ERR: $list6M() errorError: Expression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'mempool.statistics.id' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by

Anyone else?

bguillaumat · 2021-01-30T08:25:16Z

I'm seeing these logs on first boot:

api_1  | Jan 30 08:21:36 [95] ERR: $list24h() errorExpression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'mempool.statistics.id' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by
api_1  | Jan 30 08:21:36 [95] ERR: $list1W() errorError: Expression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'mempool.statistics.id' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by
api_1  | Jan 30 08:21:36 [95] ERR: $list1M() errorError: Expression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'mempool.statistics.id' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by
api_1  | Jan 30 08:21:36 [95] ERR: $list3M() errorError: Expression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'mempool.statistics.id' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by
api_1  | Jan 30 08:21:36 [95] ERR: $list6M() errorError: Expression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'mempool.statistics.id' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by
api_1  | Jan 30 08:21:36 [95] ERR: $list6M() errorError: Expression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'mempool.statistics.id' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by

Anyone else?

Yeah got the same the first time I dont know if its a error from mempool or due to me

It seems I can add option in the sql file to resolve that I'll tell you when I've tried 😉

lukechilds

Awesome stuff @bguillaumat!

Running locally for me and it's working great.

Looks like the Docker containers are running as root which we should resolve.

Also I noticed in your Dockerfiles you're running npm install. If you instead run npm ci --production it should result in much smaller Docker images.

lukechilds · 2021-01-30T08:26:54Z

apps/mempool/docker-compose.yml

+
+services:
+  web:
+    image: bguillaumat/mempool-frontend:v2.0.1


Run container as non-root:

Suggested change

image: bguillaumat/mempool-frontend:v2.0.1

image: bguillaumat/mempool-frontend:v2.0.1

user: "1000:1000"

lukechilds · 2021-01-30T08:27:15Z

apps/mempool/docker-compose.yml

+      default:
+        ipv4_address: $APP_MEMPOOL_IP
+  api:
+    image: bguillaumat/mempool-backend:v2.0.1


Run container as non-root:

Suggested change

image: bguillaumat/mempool-backend:v2.0.1

image: bguillaumat/mempool-backend:v2.0.1

user: "1000:1000"

lukechilds · 2021-01-30T08:27:27Z

apps/mempool/docker-compose.yml

+       default:
+         ipv4_address: $APP_MEMPOOL_API_IP
+  db:
+    image: bguillaumat/mempool-db:v2.0.1


Run container as non-root:

Suggested change

image: bguillaumat/mempool-db:v2.0.1

image: bguillaumat/mempool-db:v2.0.1

user: "1000:1000"

lukechilds · 2021-01-30T09:46:29Z

apps/mempool/docker-compose.yml

    logging: *default-logging
    restart: on-failure
    stop_grace_period: 1m
+    command: --sql-mode="STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION"


Maybe this belongs in the Dockerfile not the Docker Compose configuration to keep the concerns separated?

I will try to make it works on the Dockerfile 😃

lukechilds · 2021-01-30T13:31:25Z

Also just a side note but I noticed logs about writing a cache file which seems to be from here: https://github.com/mempool/mempool/blob/5f1f06fecf978b3d05e7da10fb0023e1ba9443ad/backend/src/api/disk-cache.ts#L19

It's writing the cache to a file called cache.json which can get pretty huge:

umbrel@umbrel-test:~/umbrel $ scripts/app compose mempool exec api ls -lah
total 309M
drwxr-xr-x   1 root root 4.0K Jan 30 08:27 .
drwxr-xr-x   1 root root 4.0K Jan 30 08:20 ..
-rw-rw-r--   1 root root  552 Jan 29 16:44 .gitignore
-rw-rw-r--   1 root root  346 Jan 29 16:44 Dockerfile
-rw-r--r--   1 root root 309M Jan 30 13:12 cache.json
-rw-r--r--   1 root root   14 Jan 30 13:13 cache2.json
drwxr-xr-x   3 root root 4.0K Jan 29 17:10 dist
-rw-rw-r--   1 root root   41 Jan 29 16:44 master
-rw-rw-r--   1 root root  772 Jan 30 08:21 mempool-config.json
-rw-rw-r--   1 root root 1.1K Jan 29 16:44 mempool-config.sample.json
drwxr-xr-x 146 root root 4.0K Jan 29 17:09 node_modules
-rw-rw-r--   1 root root  49K Jan 29 17:09 package-lock.json
-rw-rw-r--   1 root root 1.3K Jan 29 16:44 package.json
drwxrwxr-x   3 root root 4.0K Jan 29 16:45 src
-rwxrwxr-x   1 root root  606 Jan 29 16:44 start.sh
-rw-rw-r--   1 root root  354 Jan 29 16:44 tsconfig.json
-rw-rw-r--   1 root root 2.9K Jan 29 16:44 tslint.json
-rwxrwxr-x   1 root root 5.2K Jan 29 16:44 wait-for-it.sh

Since that's happening inside the container and not in a volume:

It won't be persisted between restarts
It is being written to the SD card not the SSD

Ideally this should be on a volume that's persisted and exists on the SSD for faster app start and less SD card wear. It's just dumped in the CWD so we'd need to add an env var to mempool like CACHE_DIR to be able to handle this better.

lukechilds · 2021-01-31T07:02:06Z

After leaving mempool running over night on my node I'm getting this error in a loop:

mempool_api_1 exited with code 1
api_1  | Jan 31 07:00:49 [26] INFO: Starting statistics service
api_1  | Jan 31 07:00:49 [26] INFO: Starting currency rates service
api_1  | /backend/dist/api/disk-cache.js:75
api_1  |             Object.assign(data.mempool, cacheData2.mempool);
api_1  |                    ^
api_1  |
api_1  | TypeError: Cannot convert undefined or null to object
api_1  |     at Function.assign (<anonymous>)
api_1  |     at DiskCache.loadMempoolCache (/backend/dist/api/disk-cache.js:75:20)
api_1  |     at Server.startServer (/backend/dist/index.js:73:30)
api_1  |     at new Server (/backend/dist/index.js:28:18)
api_1  |     at Object.<anonymous> (/backend/dist/index.js:207:16)
api_1  |     at Module._compile (internal/modules/cjs/loader.js:999:30)
api_1  |     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
api_1  |     at Module.load (internal/modules/cjs/loader.js:863:32)
api_1  |     at Function.Module._load (internal/modules/cjs/loader.js:708:14)
api_1  |     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)

Seems related to the cache file.

bguillaumat · 2021-01-31T11:24:41Z

After leaving mempool running over night on my node I'm getting this error in a loop:

mempool_api_1 exited with code 1
api_1  | Jan 31 07:00:49 [26] INFO: Starting statistics service
api_1  | Jan 31 07:00:49 [26] INFO: Starting currency rates service
api_1  | /backend/dist/api/disk-cache.js:75
api_1  |             Object.assign(data.mempool, cacheData2.mempool);
api_1  |                    ^
api_1  |
api_1  | TypeError: Cannot convert undefined or null to object
api_1  |     at Function.assign (<anonymous>)
api_1  |     at DiskCache.loadMempoolCache (/backend/dist/api/disk-cache.js:75:20)
api_1  |     at Server.startServer (/backend/dist/index.js:73:30)
api_1  |     at new Server (/backend/dist/index.js:28:18)
api_1  |     at Object.<anonymous> (/backend/dist/index.js:207:16)
api_1  |     at Module._compile (internal/modules/cjs/loader.js:999:30)
api_1  |     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
api_1  |     at Module.load (internal/modules/cjs/loader.js:863:32)
api_1  |     at Function.Module._load (internal/modules/cjs/loader.js:708:14)
api_1  |     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)

Seems related to the cache file.

I had to restart the app and it was fixed when I've implemented the volume for the cach we'll see if its fixed

bguillaumat · 2021-02-01T09:31:21Z

@lukechilds since I've put the cache files in a volume as you've said no more errors 😉

lukechilds · 2021-02-01T12:04:09Z

Awesome!

I see you're mapping a volume at ./cache/, I don't see any changes to the mempool source to use this new directory, are you manually handling it somehow?

bguillaumat · 2021-02-01T12:11:55Z

Awesome!

I see you're mapping a volume at ./cache/, I don't see any changes to the mempool source to use this new directory, are you manually handling it somehow?

Yes, in my repo I rewrite their ./cache.json & ./cache2.json to the ./cache/cache|cache2.json

lukechilds · 2021-02-01T14:05:34Z

Oh I see, nice.

Maybe it would be better if we can submit a PR and fix it properly in the mempool repo. E.g allow passing in CACHE_DIR or something. Otherwise if they ever change the file name, or set it differently, or add a new cache file it'll break again and we could easily miss it.

bguillaumat · 2021-02-01T14:57:47Z

@lukechilds Done mempool/mempool#317

I will update my repo when this will be accepted and a new build is done because my repo use a tag version not a commit
(Maybe will not be necessary if they use the PR to build their own images 😉)

softsimon · 2021-02-01T17:50:58Z

After leaving mempool running over night on my node I'm getting this error in a loop:

mempool_api_1 exited with code 1
api_1  | Jan 31 07:00:49 [26] INFO: Starting statistics service
api_1  | Jan 31 07:00:49 [26] INFO: Starting currency rates service
api_1  | /backend/dist/api/disk-cache.js:75
api_1  |             Object.assign(data.mempool, cacheData2.mempool);
api_1  |                    ^
api_1  |
api_1  | TypeError: Cannot convert undefined or null to object
api_1  |     at Function.assign (<anonymous>)
api_1  |     at DiskCache.loadMempoolCache (/backend/dist/api/disk-cache.js:75:20)
api_1  |     at Server.startServer (/backend/dist/index.js:73:30)
api_1  |     at new Server (/backend/dist/index.js:28:18)
api_1  |     at Object.<anonymous> (/backend/dist/index.js:207:16)
api_1  |     at Module._compile (internal/modules/cjs/loader.js:999:30)
api_1  |     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
api_1  |     at Module.load (internal/modules/cjs/loader.js:863:32)
api_1  |     at Function.Module._load (internal/modules/cjs/loader.js:708:14)
api_1  |     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)

Seems related to the cache file.

I had to restart the app and it was fixed when I've implemented the volume for the cach we'll see if its fixed

This bug is related to this fix mempool/mempool#304

I expect mempool v2.1 to be the release for Umbrel, it's not tagged yet.

lukechilds · 2021-02-02T04:06:44Z

Awesome, thanks @softsimon!

Either way, would be good to get mempool/mempool#317 merged too for v2.1 so we can write the cache file to a volume.

softsimon · 2021-02-02T07:54:14Z

Either way, would be good to get mempool/mempool#317 merged too for v2.1 so we can write the cache file to a volume.

Yes, that's the plan. :)

wiz

Add SHA256 hashes of the multi-architecture manifests for mempool/frontend and mempool/backend

apps/mempool/docker-compose.yml

Co-authored-by: wiz <j@wiz.biz>

wiz

Updating SHA256 hashes due to having to to move the mempool v2.1.0 tag for a last minute fix

apps/mempool/docker-compose.yml

Co-authored-by: wiz <j@wiz.biz>

bguillaumat · 2021-02-04T10:51:42Z

Updating SHA256 hashes due to having to to move the mempool v2.1.0 tag for a last minute fix

Done 🙂

lukechilds · 2021-02-05T11:07:05Z

apps/mempool/docker-compose.yml

+      MYSQL_DATABASE: "mempool"
+      MYSQL_USER: "mempool"
+      MYSQL_PASSWORD: "mempool"
+      MYSQL_ROOT_PASSWORD: "moneyprintergobrrr"


How is this password passed into the API container?

If you're just implicitly relying on the value being the same in the mempool app, it would be better to instead explicitly pass it in.

Otherwise if the default password value is ever changed in the mempool app things will suddenly break when we update and it won't be obvious why to the person implementing the update if they aren't familiar with the currently implicit password behaviour.

With the app configurations, it's always better to favour being more explicit at the cost of extra lines of code.

lukechilds · 2021-02-05T11:14:50Z

apps/mempool/docker-compose.yml

+    stop_grace_period: 1m
+    command: "./wait-for db:3306 --timeout=720 -- nginx -g 'daemon off;'"
+    ports:
+      - ${APP_MEMPOOL_PORT}:8080


This is running on port 8080 on the container but $APP_MEMPOOL_PORT (3006) on the host.

This breaks the hidden service which is proxying to <app-mempool-ip>:<app-mempool-port> when the app is actually running at <app-mempool-ip>:8080.

It should be running on APP_MEMPOOL_PORT on the container too:

Suggested change

- ${APP_MEMPOOL_PORT}:8080

- ${APP_MEMPOOL_PORT}:${APP_MEMPOOL_PORT}

You'll also need to pass this value to the NGINX to tell it to run on that port instead of 8080.

louneskmt

I think you shouldn't have removed the api container IP, as all containers need a fixed IP address in order to prevent IP collisions.

lukechilds · 2021-02-05T11:25:54Z

Yes, @louneskmt is correct, it's ok to refer to containers via the hostname, you don't need to refer via IP, but you do still need to assign a static IP to the container, otherwise we'll get collisions.

This reverts commit da11391.

lukechilds · 2021-02-05T13:12:46Z

apps/mempool/docker-compose.yml

    restart: on-failure
    stop_grace_period: 1m
-    command: "./wait-for db:3306 --timeout=720 -- nginx -g 'daemon off;'"
+    command: /bin/sh -c "cp /etc/nginx/nginx.conf /patch/nginx.conf && sed -i 's/8080/${APP_MEMPOOL_PORT}/g' /patch/nginx.conf && ./wait-for db:3306 --timeout=720 -- nginx -g 'daemon off;' -c /patch/nginx.conf"


This should be done in the mempool Docker image, not from our side.

This still implicitly relies on the port being hardcoded to 8080 in the mempool source.

We should be able to pass in a PORT env var to the mempool image that tells it to run the server on that port.

Also I'd recommend using envsubst not hand rolling it with sed. If the NGINX config is ever changed to include the string 8080 elsehwere, (a hash?) this sed script will break the configuration file.

Okay sure but if this is the only issue I would prefer to fix it in a future release

I've made a PR to handle this case and the MySQL vars

@lukechilds This is fixed in the last version of Mempool (v2.1.1)
Thanks to @wiz 🚀

wiz

ACK @ 9373bc0

mempool/frontend:v2.1.1@sha256:17e7fedcd27b6f99de2f159f0f6372b76dd5825f1a98c1b0114ea9564cab1c0e
mempool/backend:v2.1.1@sha256:c15c3d1af0f9df4672f3760b0ff9b79d1dd60235cde7316a7860b1d650b31360

lukechilds · 2021-02-11T12:05:47Z

@bguillaumat can you enable edits from maintainers so I can push some tweaks to your branch?

Then this is good to be merged! 🎉

lukechilds

Great job everyone!

mayankchhabra · 2021-02-12T07:11:54Z

Seriously awesome work on this, @bguillaumat and everyone!

Gallery images here: getumbrel/umbrel-apps-gallery#1

Meanwhile, @wiz and @softsimon, feel free to suggest/update the tagline (max 50 chars) and description (max 200 words) that you'd like to see in the app store.

Add mempool.space v2 (getumbrel#452)

b7b0d98

louneskmt suggested changes Jan 29, 2021

View reviewed changes

Clean docker-compose

9d61783

bguillaumat force-pushed the mempool-v2 branch from 0c33e79 to 9d61783 Compare January 29, 2021 17:42

lukechilds requested changes Jan 30, 2021

View reviewed changes

Fix mysql error (ONLY_FULL_GROUP_BY)

4129858

lukechilds reviewed Jan 30, 2021

View reviewed changes

bguillaumat added 2 commits January 31, 2021 15:50

Run mempool as non-root && Handle API cache.json

efa74e0

Add sha256sum

22f6b15

Update frontend sha256

0b6ad47

bguillaumat added 2 commits February 3, 2021 10:12

Update docker-compose with mempool official build

347f447

Set mempool to v2.1.0

26da6a4

wiz suggested changes Feb 3, 2021

View reviewed changes

apps/mempool/docker-compose.yml Outdated Show resolved Hide resolved

apps/mempool/docker-compose.yml Outdated Show resolved Hide resolved

Add SHA256 of Mempool images

c45db46

Co-authored-by: wiz <j@wiz.biz>

wiz suggested changes Feb 4, 2021

View reviewed changes

apps/mempool/docker-compose.yml Outdated Show resolved Hide resolved

apps/mempool/docker-compose.yml Outdated Show resolved Hide resolved

Apply new sha256

41d4ce4

Co-authored-by: wiz <j@wiz.biz>

Remove mysql-mempool.cnf

20468cc

lukechilds reviewed Feb 5, 2021

View reviewed changes

lukechilds requested changes Feb 5, 2021

View reviewed changes

Remove useless IPV4 & use of container name

da11391

louneskmt reviewed Feb 5, 2021

View reviewed changes

bguillaumat added 2 commits February 5, 2021 12:29

Revert "Remove useless IPV4 & use of container name"

46b8ac5

This reverts commit da11391.

Explicitly add mysql conf in API & Update ningx conf for Tor

51f967f

lukechilds requested changes Feb 5, 2021

View reviewed changes

bguillaumat added 2 commits February 10, 2021 15:10

Update docker-compose for new Mempool v2.1.1

4e462be

Update sha256 sum for 2.1.1

9373bc0

wiz previously approved these changes Feb 11, 2021

View reviewed changes

lukechilds added 2 commits February 11, 2021 19:03

clean up whitespace

b264b5d

Inject contianer init system for correct signal handling

dac64c0

lukechilds dismissed wiz’s stale review via dac64c0 February 11, 2021 12:21

Consistent variable style

136ca2f

lukechilds approved these changes Feb 11, 2021

View reviewed changes

lukechilds changed the title ~~Add mempool.space app v2~~ Add mempool app Feb 11, 2021

lukechilds merged commit b53a9c9 into getumbrel:master Feb 11, 2021

mayankchhabra mentioned this pull request Feb 12, 2021

Add mempool getumbrel/umbrel-apps-gallery#1

Merged

mayankchhabra mentioned this pull request Feb 12, 2021

Add mempool to app store registry #508

Merged

	image: bguillaumat/mempool-frontend:v2.0.1
	image: bguillaumat/mempool-frontend:v2.0.1
	user: "1000:1000"

	image: bguillaumat/mempool-backend:v2.0.1
	image: bguillaumat/mempool-backend:v2.0.1
	user: "1000:1000"

	image: bguillaumat/mempool-db:v2.0.1
	image: bguillaumat/mempool-db:v2.0.1
	user: "1000:1000"

	- ${APP_MEMPOOL_PORT}:8080
	- ${APP_MEMPOOL_PORT}:${APP_MEMPOOL_PORT}

Add mempool app #470

Add mempool app #470

Uh oh!

Conversation

bguillaumat commented Jan 29, 2021 • edited by mayankchhabra Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

App Submission

App name

Version

One line description of the app

Summary of the app

Developed by

Developer website

Source code repository

Support link

Uses

256x256 SVG icon

App screenshots

I have tested my app on:

Uh oh!

louneskmt commented Jan 29, 2021

Uh oh!

bguillaumat commented Jan 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bguillaumat Jan 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lukechilds Jan 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bguillaumat Jan 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bguillaumat commented Jan 29, 2021

Uh oh!

louneskmt commented Jan 29, 2021

Uh oh!

lukechilds commented Jan 30, 2021

Uh oh!

bguillaumat commented Jan 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lukechilds left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lukechilds commented Jan 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lukechilds commented Jan 31, 2021

Uh oh!

bguillaumat commented Jan 31, 2021

Uh oh!

bguillaumat commented Feb 1, 2021

Uh oh!

lukechilds commented Feb 1, 2021

Uh oh!

bguillaumat commented Feb 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

bguillaumat commented Jan 29, 2021 •

edited by mayankchhabra

Loading

bguillaumat commented Jan 29, 2021 •

edited

Loading

bguillaumat Jan 29, 2021 •

edited

Loading

lukechilds Jan 30, 2021 •

edited

Loading

bguillaumat Jan 29, 2021 •

edited

Loading

bguillaumat commented Jan 30, 2021 •

edited

Loading

lukechilds commented Jan 30, 2021 •

edited

Loading

bguillaumat commented Feb 1, 2021 •

edited

Loading

lukechilds commented Feb 1, 2021 •

edited

Loading

bguillaumat commented Feb 1, 2021 •

edited

Loading

softsimon commented Feb 1, 2021 •

edited

Loading

lukechilds Feb 5, 2021 •

edited

Loading

lukechilds commented Feb 5, 2021 •

edited

Loading

lukechilds Feb 5, 2021 •

edited

Loading

bguillaumat Feb 6, 2021 •

edited

Loading

bguillaumat Feb 10, 2021 •

edited

Loading