Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Who's using it? #100

Closed
Keats opened this Issue Jul 14, 2017 · 9 comments

Comments

Projects
None yet
6 participants
@Keats
Copy link
Collaborator

Keats commented Jul 14, 2017

@pka

This comment has been minimized.

@crawfxrd

This comment has been minimized.

Copy link

crawfxrd commented Aug 4, 2017

@reillysiemens

This comment has been minimized.

@17cupsofcoffee

This comment has been minimized.

@Keats

This comment has been minimized.

Copy link
Collaborator Author

Keats commented Oct 2, 2017

@17cupsofcoffee Nice! You mention some bugs in your article, is there anything not fixed compared to the next version (0.1.4) https://github.com/Keats/gutenberg/blob/master/CHANGELOG.md?

@17cupsofcoffee

This comment has been minimized.

Copy link
Contributor

17cupsofcoffee commented Oct 2, 2017

@Keats I had a couple of instances of stuff acting weird with the live reload (might have been when I edited and saved before another build had finished?), but I've not dug into what the issue was yet - nothing that hitting save again/restarting the server couldn't fix though. Other than that, it was pretty much plain sailing! Looking forward to trying out the new version :)

@Keats

This comment has been minimized.

Copy link
Collaborator Author

Keats commented Oct 3, 2017

Yeah live reload is the part where it's most likely to have noticeable issues as I'm trying to only reload what's needed but I can't guess what's being used in the templates. Maybe it would make sense to default to a dumb reload (just rebuild the whole site - it will be fast enough for most sites) but have a way to enable the current smart reload in config.toml since if you have a few thousands pages, it's better than a full rebuild.

#122 is related if someone wants to tackle it but I don't think it will be possible to write a perfect smart reload short of keeping track what variables/global functions are being used in the templates.

@sirodoht

This comment has been minimized.

@Keats

This comment has been minimized.

Copy link
Collaborator Author

Keats commented Jan 25, 2018

List is in the README and probably going to be in the site as well so this issue can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.