New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting: line numbers #232

Closed
PhilipDaniels opened this Issue Feb 18, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@PhilipDaniels
Copy link
Contributor

PhilipDaniels commented Feb 18, 2018

It would be nice to have an option to turn on line numbering for the syntax highlighting.

@Keats Keats added the enhancement label Feb 19, 2018

@Keats

This comment has been minimized.

Copy link
Collaborator

Keats commented Feb 19, 2018

Definitely something I'd like to have but needs to #160 and #165 first

@Keats

This comment has been minimized.

Copy link
Collaborator

Keats commented Feb 20, 2018

A tricky thing is finding a way to make the line numbers match the theme being used

@PhilipDaniels

This comment has been minimized.

Copy link
Contributor Author

PhilipDaniels commented Feb 21, 2018

Yes, I was a bit surprised to see there are no css classes used for the code, it's all inline styles. Makes me think that this should actually be implemented upstream, in syntect. I did a quick search in that repo and there are no issues about it.

@Keats

This comment has been minimized.

Copy link
Collaborator

Keats commented Nov 23, 2018

Closing in favour of the discourse post https://zola.discourse.group/t/highlighting-improvements/19

@Keats Keats closed this Nov 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment