Handle csv parsing error when encountering rows with different lengths #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good! |
mziter
changed the title
Keats
reviewed
Feb 9, 2019
| e, | ||
| )); | ||
| } | ||
| }; |
There was a problem hiding this comment.
you want to use zola errors, not tera ;)
I believe you can replace this line by
let record = result..map_err(|e| Error::chain("Error encountered when parsing csv records", e))?;There was a problem hiding this comment.
Sure, sorry about the oversight. I'll take a look soon and update PR.
There was a problem hiding this comment.
Sorry actually, I just realised this is a Tera function so using the Tera error makes sense/is required!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code is calling unwrap on each row that results from csv crate parsing logic. This has been changed to match and map an error result into the expected Teraform error with chaining. Associated unit test has been added.