Skip to content

Add title and body to alias page#830

Merged
Keats merged 1 commit into
getzola:nextfrom
spk:fix-redirect-body
Oct 28, 2019
Merged

Add title and body to alias page#830
Keats merged 1 commit into
getzola:nextfrom
spk:fix-redirect-body

Conversation

@spk

@spk spk commented Oct 27, 2019

Copy link
Copy Markdown
Contributor

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code changes

  • Are you doing the PR on the next branch?

This ensure the redirect page have a title and a body with a link in case the browser does not handle refresh redirects

@Keats

Keats commented Oct 28, 2019

Copy link
Copy Markdown
Collaborator

Hmm why? Which browser does not support the http-equiv="refresh"?

@spk

spk commented Oct 28, 2019

Copy link
Copy Markdown
Contributor Author

With firefox this can be disabled with accessibility.blockautorefresh = true currently we have a blank page. A good practice is to have a title and body to show what we are trying to do and give more information to the user blocking auto refresh

@Keats

Keats commented Oct 28, 2019

Copy link
Copy Markdown
Collaborator

Ok, i'm guessing these don't need to be translated as it will be a very niche situation. Thanks!

@Keats
Keats merged commit 83363d8 into getzola:next Oct 28, 2019
@spk
spk deleted the fix-redirect-body branch October 28, 2019 19:16
Keats pushed a commit that referenced this pull request Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants