New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete _socket3._fileobject #1084

Closed
jamadden opened this Issue Jan 29, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@jamadden
Member

jamadden commented Jan 29, 2018

This must be a porting legacy. The standard library does not have a _fileobject attribute in socket, and socket.makefile() is implemented in terms of the IO library and socket.SocketIO. I can't see any reason why we should have this unused code sitting around.

@jamadden jamadden added the python3 label Jan 29, 2018

@jamadden jamadden added this to the 1.3 milestone Jan 29, 2018

@jamadden jamadden closed this in 17598c2 Jan 29, 2018

jamadden added a commit that referenced this issue Jan 29, 2018

Merge pull request #1086 from gevent/issue1084
Drop the unused gevent._socket3._fileobject class. Fixes #1084.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment