Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.8 #1430

Closed
jamadden opened this issue Jun 11, 2019 · 9 comments
Closed

Support Python 3.8 #1430

jamadden opened this issue Jun 11, 2019 · 9 comments
Labels
PyVer: python3 Affects Python 3 Type: Enhancement We can do better through adding this

Comments

@jamadden
Copy link
Member

Now that beta1 is out, it's time to start work on supporting 3.8.

First step is to add it to CI and make sure the generic tests pass.

Then the next step is to add its stdlib unit tests and make them pass.

@jamadden jamadden added Type: Enhancement We can do better through adding this PyVer: python3 Affects Python 3 labels Jun 11, 2019
@alexprengere
Copy link

Currently on Python3.7b1, I cannot install gevent 1.4 from PyPI (compilation fails with an error related to PyCode_New), but everything works fine when I install from master (I have a test suite using gevent that passes too).
So I guess we are one release away from supporting Python3.8 😄

@jamadden
Copy link
Member Author

Currently on Python3.7b1, I cannot install gevent 1.4 from PyPI (compilation fails with an error related to PyCode_New)

gevent 1.4 is tested and supported on Python 3.7. Perhaps upgrading to a Python 3.7 final release would help? I do recall breakage in an C API pretty late in the game and Cython had to be updated to workaround it.

@jamadden
Copy link
Member Author

3.8b4 support landed in #1456

@jodal
Copy link

jodal commented Oct 15, 2019

Python 3.8 has now been released. Can we have a gevent release so that libraries depending on gevent can start supporting Python 3.8 too?

@jamadden
Copy link
Member Author

gevent 1.5a2 has been released to PyPI. Wheels are still building and will be uploaded when complete. (Note that there will be no Windows wheels for 3.8 as 3.8 is not available on Appveyor yet.)

@tlolkema
Copy link

gevent 1.5a2 has been released to PyPI. Wheels are still building and will be uploaded when complete. (Note that there will be no Windows wheels for 3.8 as 3.8 is not available on Appveyor yet.)

It looks like Appveyor supports 3.8 now:
appveyor/ci#3142 (comment)

@filips123
Copy link

@jamadden Will stable 1.5 with support for Python 3.8 be released soon?

@jamadden
Copy link
Member Author

jamadden commented Apr 5, 2020

There are releases of gevent 1.5 that support Python 3.8 now. Just because it's 1.5a4 doesn't mean "don't use it". gevent never makes a release that isn't suitable for production.

The 'a' is a strict interpretation of semantic versioning meaning that the new API is still subject to change. I could release the exact same code as 1.5.0, but that's a false signal and we'd burn though numbers pretty quickly (we'd be at something like 1.25 by now).

@ehmkah
Copy link

ehmkah commented Apr 9, 2020

I understand that you do not want to burn the release numbers to fast. But 1.5a4 stills seems to be a pre-release. Would it be possible to make it a "real"-release? My company policy says "no prereleases". :-( I am a not a python-expert so I do not know what the implications are if such a release has been delivered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyVer: python3 Affects Python 3 Type: Enhancement We can do better through adding this
Projects
None yet
Development

No branches or pull requests

6 participants