Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gevent.selectors:GeventSelector #1532

Closed
jamadden opened this issue Feb 5, 2020 · 3 comments · Fixed by #1636
Closed

Add gevent.selectors:GeventSelector #1532

jamadden opened this issue Feb 5, 2020 · 3 comments · Fixed by #1636
Assignees
Labels
Type: Enhancement
Milestone

Comments

@jamadden
Copy link
Member

jamadden commented Feb 5, 2020

This would be a full featured Selector implementation taking advantage of gevent internals.

Ideally, it would exist on Python 2 with a compatible API to help apps transition (maybe there's a backport library for the base selector?).

See details in #1523 (comment)

@jamadden jamadden added the Type: Enhancement label Feb 5, 2020
@jamadden jamadden added this to the 1.5.0 milestone Feb 5, 2020
@jamadden jamadden self-assigned this Jun 3, 2020
jamadden added a commit that referenced this issue Jun 4, 2020
Fixes #1532, but there's potentially room for optimization. Committing the simple version for CI tests.
@hashbrowncipher
Copy link
Contributor

hashbrowncipher commented Jun 12, 2020

I have this deployed and it's working great. Thanks for doing all of the work to get it merged!

@jamadden
Copy link
Member Author

jamadden commented Jun 13, 2020

Thanks for the feedback! It's rare to get feedback of any kind, let alone positive.

@vytas7
Copy link

vytas7 commented Mar 7, 2021

It's rare to get feedback of any kind

Oh, c'mon... The only reason for the above I can think of is that gevent works really well, and people are more vocal when things don't. I'm pretty sure the battle-tested gevent is still very widely used.

And you're doing a great job maintaining it 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants