Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libuv child watchers prevent the loop from exiting #1581

Closed
jamadden opened this issue Apr 21, 2020 · 0 comments · Fixed by #1582
Closed

libuv child watchers prevent the loop from exiting #1581

jamadden opened this issue Apr 21, 2020 · 0 comments · Fixed by #1582
Labels
Type: Bug

Comments

@jamadden
Copy link
Member

@jamadden jamadden commented Apr 21, 2020

Using one just once leaves a referenced signal watcher around, which keeps the loop from exiting. libev doesn't have this issue.

@jamadden jamadden added the Type: Bug label Apr 21, 2020
jamadden added a commit that referenced this issue Apr 21, 2020
Fixes #1581.

This was exposed by running test__os and test__queue in the same process in that order. test__os watches children,
and test__queue has a test that expects a LoopExit. It wasn't raised because the child watcher (really the signal watcher)
was referenced, keeping the loop running.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant