Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gevent DummyThread objects use the wrong name. #1659

Closed
jamadden opened this issue Jul 22, 2020 · 0 comments · Fixed by #1662
Closed

gevent DummyThread objects use the wrong name. #1659

jamadden opened this issue Jul 22, 2020 · 0 comments · Fixed by #1662
Labels
Type: Bug Identified as a bug; needs a code change to fix

Comments

@jamadden
Copy link
Member

jamadden commented Jul 22, 2020

They use DummyThread-1234:

# It'd be nice to use a pattern like "greenlet-%d", but maybe somebody out
# there is checking thread names...
self._name = self._Thread__name = __threading__._newname("DummyThread-%d")

But the standard library uses Dummy- from the origin of the threading module in Python 2.0 all the way up to 3.9.

There are in fact third-party libraries that check against the thread name.

This has been broken since gevent 1.2a2.

@jamadden jamadden added the Type: Bug Identified as a bug; needs a code change to fix label Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Identified as a bug; needs a code change to fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant