Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with dnspython 2 #1661

Closed
jamadden opened this issue Jul 22, 2020 · 1 comment
Closed

Incompatible with dnspython 2 #1661

jamadden opened this issue Jul 22, 2020 · 1 comment

Comments

@jamadden
Copy link
Member

jamadden commented Jul 22, 2020

Some of the details we rely on have been removed and leave the dnspython resolver completely broken.

cf rthalley/dnspython#473

@jamadden
Copy link
Member Author

jamadden commented Jul 22, 2020

Sigh. This is a bigger deal than I thought.

  • There are many times where dnspython2 wants to call back into the system resolver now (socket.whatever). That doesn't work because the system resolver is gevent, which uses dnspython2, which calls the system resolver, which…ultimately ends up crashing the interpreter in a recursion error.

  • dns.resolver.query is now deprecated and calls through to dns.resolver.resolve, as do many other things (rthalley/dnspython@997e913). Our resolver implementation doesn't have that.

It may be that the two changes together mean that our DualResolver isn't really needed anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant