New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make callbacks.c stop relying on implementation details of Cython and Python #1080

Merged
merged 1 commit into from Jan 25, 2018

Conversation

Projects
None yet
1 participant
@jamadden
Member

jamadden commented Jan 25, 2018

Instead use documented ways to interact.

This gets rid of the callbacks.c hack, our reliance on private vtables, and our reliance on undocumented members of PyThreadState. The functions compile to essentially the same C code.

Make callbacks.c stop relying on implementation details of Cython and…
… Python. Instead use documented ways to interact.

@jamadden jamadden merged commit 925dc02 into master Jan 25, 2018

4 of 5 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.09%) to 75.179%
Details

jamadden added a commit that referenced this pull request Jan 25, 2018

@jamadden jamadden deleted the callbacks-cleanup branch Jan 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment