New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monitoring for memory usage, emitting events as it moves around the threshold. #1150

Merged
merged 3 commits into from Mar 23, 2018

Conversation

Projects
None yet
1 participant
@jamadden
Member

jamadden commented Mar 22, 2018

Builds on #1147.

Still needs specific tests, hence the WIP.

I may try to add some simple default policies that can be turned on with simple config switches (e.g., gc then kill if still too high the next time) in this or a subsequent PR. I'm not 100% sure if that would be useful to anyone or not though, so feedback welcome (as always).

When this (and/or the default policies) land, I think that will conclude what I was hoping to get done for #1021 for 1.3.

(cc @jzuech3 @papachoco @cutz)

@jamadden jamadden changed the title from Add monitoring for memory usage, emitting events as it moves around t… to [WIP] Add monitoring for memory usage, emitting events as it moves around the threshold. Mar 22, 2018

@jamadden jamadden changed the title from [WIP] Add monitoring for memory usage, emitting events as it moves around the threshold. to Add monitoring for memory usage, emitting events as it moves around the threshold. Mar 23, 2018

@jamadden jamadden force-pushed the mem-monitor branch from a507cd3 to 0a56f56 Mar 23, 2018

@jamadden jamadden merged commit 277e34c into master Mar 23, 2018

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.06%) to 83.998%
Details

@jamadden jamadden deleted the mem-monitor branch Mar 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment