Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP/1.0 should support client header: Connection: Keep-Alive #1331

Closed
wants to merge 2 commits into from

Conversation

@tanchuhan
Copy link

tanchuhan commented Dec 24, 2018

HTTP/1.0 should support client header: Connection: Keep-Alive

@tanchuhan

This comment has been minimized.

Copy link
Author

tanchuhan commented Dec 24, 2018

wiki link about Connection header:
https://en.wikipedia.org/wiki/HTTP_persistent_connection#HTTP_1.0
i think we should support Keep-Alive in HTTP/1.0

@jamadden

This comment has been minimized.

Copy link
Member

jamadden commented Dec 24, 2018

Thanks for the PR!

The link you provided points out that this is not a part of the standard. Can you explain why gevent should implement a non-standard extension to an obsolete protocol?

@tanchuhan

This comment has been minimized.

Copy link
Author

tanchuhan commented Dec 24, 2018

thx for reply,
i found out this problem because i runned ab(apache benchmark) to test my pywsgi program. ab suppors argument -k to send request header Connection: Keep-Alive,unfortunately ab just send HTTP/1.0 version to server.
in my opinion, maybe it's a good feature
to support keep-alive in HTTP/1.0(just as another client/server programs doing)

jamadden added a commit that referenced this pull request Dec 8, 2019
With tests. Supercedes #1331.
@jamadden

This comment has been minimized.

Copy link
Member

jamadden commented Dec 8, 2019

Updated and merged in #1490.

@jamadden jamadden closed this Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.