Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monkey: allow to execute a module rather than only a script #1440

Merged
merged 1 commit into from Sep 6, 2019

Conversation

@jd
Copy link
Contributor

commented Jul 25, 2019

No description provided.

@jamadden
Copy link
Member

left a comment

Thanks for the PR!

I left some minor feedback that needs addressed. In addition, there needs to be a test case added (test__monkey_scope.py would be a good place probably), and an entry in CHANGES.rst.

The TravisCI failures are unrelated, apparently certs need updated.

src/gevent/monkey.py Outdated Show resolved Hide resolved
src/gevent/monkey.py Outdated Show resolved Hide resolved
src/gevent/monkey.py Show resolved Hide resolved

@jd jd force-pushed the jd:run_module branch 2 times, most recently from 9bb579c to 851c372 Jul 25, 2019

@jd jd force-pushed the jd:run_module branch from 851c372 to 1a39110 Jul 26, 2019

@jamadden

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

Thanks for this PR! I apologize for the delayed response, I've been fully occupied with other projects. I'll get back to this as soon as I can.

@jamadden jamadden merged commit 02b73a4 into gevent:master Sep 6, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jamadden added a commit that referenced this pull request Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.