From 682df8c6a9f0a4af5a9acced0206b9ff49e8020c Mon Sep 17 00:00:00 2001 From: gfichtenholt Date: Tue, 21 Sep 2021 23:07:09 -0700 Subject: [PATCH] Michael feedback #1 --- .../fluxv2/packages/v1alpha1/integration_utils_test.go | 8 +++++--- .../plugins/fluxv2/packages/v1alpha1/release_test.go | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/cmd/kubeapps-apis/plugins/fluxv2/packages/v1alpha1/integration_utils_test.go b/cmd/kubeapps-apis/plugins/fluxv2/packages/v1alpha1/integration_utils_test.go index 96e1dd99e58..eeb7b29c9cb 100644 --- a/cmd/kubeapps-apis/plugins/fluxv2/packages/v1alpha1/integration_utils_test.go +++ b/cmd/kubeapps-apis/plugins/fluxv2/packages/v1alpha1/integration_utils_test.go @@ -332,6 +332,8 @@ func randSeq(n int) string { } // global vars -var letters = []rune("abcdefghijklmnopqrstuvwxyz0123456789") -var typedClient kubernetes.Interface -var dynamicClient dynamic.Interface +var ( + dynamicClient dynamic.Interface + typedClient kubernetes.Interface + letters = []rune("abcdefghijklmnopqrstuvwxyz0123456789") +) diff --git a/cmd/kubeapps-apis/plugins/fluxv2/packages/v1alpha1/release_test.go b/cmd/kubeapps-apis/plugins/fluxv2/packages/v1alpha1/release_test.go index 6b81687ae24..e12f1e6f404 100644 --- a/cmd/kubeapps-apis/plugins/fluxv2/packages/v1alpha1/release_test.go +++ b/cmd/kubeapps-apis/plugins/fluxv2/packages/v1alpha1/release_test.go @@ -656,7 +656,7 @@ func TestUpdateInstalledPackage(t *testing.T) { expectedRelease: flux_helm_release_updated_1, }, { - name: "returns invalid if installed package doesn't exist", + name: "returns not found if installed package doesn't exist", request: &corev1.UpdateInstalledPackageRequest{ InstalledPackageRef: &corev1.InstalledPackageReference{ Context: &corev1.Context{