Gordon Fontenot gfontenot

Organizations

thoughtbot, inc.
gfontenot commented on pull request thoughtbot/Argo#72
Gordon Fontenot

Fixes #67

gfontenot commented on pull request thoughtbot/Argo#72
Gordon Fontenot

We should also use the shorthand for the dictionary type.

gfontenot commented on pull request thoughtbot/Argo#72
Gordon Fontenot

I'd also rename type to expectedType for clarity.

gfontenot commented on pull request thoughtbot/Argo#72
Gordon Fontenot

I do think this is useful enough for users that want to write their own parsers that it should probably be public. But I still think it should be a…

gfontenot commented on pull request thoughtbot/Argo#72
Gordon Fontenot

It's odd to me that this acts differently than every other decode* function. Everything else returns a fully decoded object, while this still returns

gfontenot commented on pull request thoughtbot/Argo#72
Gordon Fontenot

Why do we all of a sudden need this function?

gfontenot commented on pull request thoughtbot/Argo#72
Gordon Fontenot

Just making a note here that we should figure out a better name.

gfontenot commented on issue robrix/Box#16
Gordon Fontenot

Ha. Handy. Thanks. Have a preferred version number? 1.1.0?

gfontenot opened issue robrix/Box#16
Gordon Fontenot
Tag new version?
gfontenot commented on pull request thoughtbot/Argo#72
Gordon Fontenot

But we'd need this to be public in order to let users write more complex parsers. Like, for example, the ability to write parsers for NSURL (like w…

gfontenot commented on pull request thoughtbot/Argo#72
Gordon Fontenot

Oh, right. Gross. Well, we should at least rely on an existing implementation then.

gfontenot commented on pull request thoughtbot/Argo#72
Gordon Fontenot

So it looks like we would need to expose this to users in order to let them write custom parsers. In that case, can we move these onto Parser as st…

gfontenot commented on pull request thoughtbot/Argo#72
Gordon Fontenot

I really (really) dislike the introduction of this function, so if we can get rid of it, that would be great.

gfontenot commented on pull request thoughtbot/Argo#72
Gordon Fontenot

This feels poorly named to me.

gfontenot commented on pull request thoughtbot/Argo#72
Gordon Fontenot

I don't think the user needs access to this. We should probably default to internal, instead of defaulting to public.

gfontenot commented on pull request thoughtbot/Argo#72
Gordon Fontenot

@tonyd256 No, exposing Parser doesn't expose Box. This should really be internal. We'd only need to expose this if we allowed users to get at the b…

gfontenot commented on pull request thoughtbot/Argo#72
Gordon Fontenot

maybe seems like a weird name here. Should this be called optional? Also, the type signature feels un-swifty to me. Also, why isn't this just f <^>…

gfontenot commented on pull request thoughtbot/Argo#72
Gordon Fontenot

Couldn't this just be named decode as well? If not, it should be decodeParser instead of decodeResult.

gfontenot commented on pull request thoughtbot/Argo#72
Gordon Fontenot

Should this be public? If so, should we rely on robrix/Box?

gfontenot commented on pull request thoughtbot/Argo#72
Gordon Fontenot

should these be public?

gfontenot opened pull request thoughtbot/Argo#71
Gordon Fontenot
Reorganize repo
3 commits with 106 additions and 133 deletions
Gordon Fontenot
gfontenot deleted branch gf-no-subscript at thoughtbot/Argo
Gordon Fontenot
gfontenot merged pull request thoughtbot/Argo#66
Gordon Fontenot
Remove JSON subscripting
4 commits with 42 additions and 35 deletions
Gordon Fontenot
Have JSONValue conform to JSONDecodable
Gordon Fontenot