Gordon Fontenot gfontenot

Organizations

@thoughtbot @antitypical
gfontenot commented on issue thoughtbot/liftoff#230
@gfontenot

I think I noticed yesterday that our unit test bundles don't have the run path search paths configured properly, but I haven't had time to confirm.…

gfontenot commented on issue thoughtbot/Tropos#134
@gfontenot

We can drop the prefix with Swift. Modules act as namespaces, so they aren't needed for interop.

gfontenot commented on pull request thoughtbot/Argo#162
@gfontenot

What's the reasoning behind this change?

gfontenot commented on issue thoughtbot/Tropos#134
@gfontenot

We should move to Quick and Nimble for Swift, not bare XCTest.

gfontenot commented on pull request thoughtbot/Tropos#126
@gfontenot

FWIW, CocoaPods handles Swift just fine, so our decision around dependency management isn't really affected by the language we're choosing. That be…

gfontenot commented on issue thoughtbot/Argo#149
@gfontenot

We aren't relying on NSJSONSerialization or NSData internally (AFAIK), so that's not really our concern. That would be a concern for whoever makes …

gfontenot commented on pull request thoughtbot/docker-files#3
@gfontenot

I think the point here was that this is how to set it up without docker-compose. If you need database support, then you'd want to use docker-compose,…

gfontenot commented on pull request thoughtbot/docker-files#2
@gfontenot

:+1:

gfontenot commented on pull request thoughtbot/docker-files#1
@gfontenot

this won't work till we have a latest tag working

gfontenot commented on pull request thoughtbot/guides#335
@gfontenot

Fwiw, we typically use _foo to indicate an internal (private) variable, not an ignored variable in Swift/ObjC.

gfontenot commented on pull request thoughtbot/Argo#153
@gfontenot

I don't know how I feel about this, to be honest. Few general thoughts: The <| family of operators don't really have a place in this implementatio…

gfontenot commented on pull request thoughtbot/Argo#153
@gfontenot

Yep, that's exactly right. This typealias exists to help with :ghost: INHERITANCE :ghost:

gfontenot commented on pull request thoughtbot/Argo#153
@gfontenot

does it need the nil coalescer?

gfontenot commented on issue thoughtbot/Argo#139
@gfontenot

I think these new approaches are super interesting, but generally out of scope for what Argo is trying to do (functional JSON decoding). I'd probab…

gfontenot commented on issue thoughtbot/Argo#151
@gfontenot

I think it's probably better for us to have a type that fits in well with some (if not all) users, than a type that doesn't fit in with any users. …

gfontenot commented on pull request thoughtbot/Runes#37
@gfontenot

:+1:

@gfontenot
Switch from custom `Decoded<T>` type to `Result<T: Decodable, DecodingError>`?
@gfontenot
Use `throws` syntax instead of returning `Decoded<T>`?
gfontenot commented on issue thoughtbot/Argo#149
@gfontenot

AFAIK, this is basically just removing our dependency on NSNumber

@gfontenot
Remove dependency on Foundation
gfontenot commented on pull request thoughtbot/Tropos#106
@gfontenot

Yeah, that makes more sense to me. Maybe wait for feedback from @hyperspacemark?

gfontenot commented on pull request antitypical/Result#62
@gfontenot

maybe add something along the lines of this makes functions using the Result type much more composable than solutions using throw ?

gfontenot commented on pull request antitypical/Result#62
@gfontenot

I'd also note here that the opposite function (dematerialize) is available to access the value or throw.

@gfontenot
Add CoC to contributing guidelines
gfontenot commented on issue thoughtbot/liftoff#228
@gfontenot

donezo

gfontenot deleted branch gf-update-readme-coc at thoughtbot/liftoff
@gfontenot
gfontenot merged pull request thoughtbot/liftoff#229
@gfontenot
Update README and add CoC
2 commits with 33 additions and 11 deletions
gfontenot commented on pull request thoughtbot/Tropos#106
@gfontenot

one question about side effects, one tiny style nitpick. But this looks pretty good to me.

gfontenot commented on pull request thoughtbot/Tropos#106
@gfontenot

remove extra newline