Run flake8 across this codebase #16
Conversation
There was a problem hiding this comment.
Thanks for spending the time cleaning up my mess!! 🎉
There's a couple of small changes I would like to make on your changes, if you wish I can do them myself if you want. Just let me know.
Again, thanks for caring so much to send a couple of pull requests already!!
setup.cfg
Outdated
| @@ -1,3 +1,6 @@ | |||
| [flake8] | |||
| max-line-length=100 | |||
There was a problem hiding this comment.
Would you mind changing that to 80? I usually work with two or three editors one next to each other and 80 is the perfect size for that.
tox.ini
Outdated
| commands= | ||
| flake8 |
There was a problem hiding this comment.
That does not work, you should instead put flake8 *.py
flake8 spotted that there was a duplicate entry in the dictionary so it's probably worth running as part of the tests.
alexmuller
force-pushed
the
run-flake8-on-this-codebase
branch
from
69a4d8f
to
3a1a35b
Compare
|
No problem at all! Updated this pull request, sorry for the delay :) |
|
@alexmuller thanks! I will release it shortly, ping me back if I did not do it. |
|
@alexmuller released 1.3 let me know if something is broken 🙂 |
flake8 spotted that there was a duplicate entry in the dictionary so it's probably worth running as part of the tests.
I don't know tox at all so I may have done this in the wrong place.