New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagination widget when single number of entries is given #32

Merged
merged 1 commit into from May 22, 2017

Conversation

Projects
None yet
2 participants
@zeehio
Copy link
Contributor

zeehio commented May 22, 2017

htmlTable::htmlTableWidget accepts number_of_entries to control the number of rows to show per page. By default we see this "Show 10 entries":
imatge

However, when number_of_entries is a single number, htmlTableWidget still was showing a select menu that was non-functional.

With this PR, if number of entries is not an array we don't create the "Select [10|20|50] entries" label rendering something like this:

imatge

Note how the "Show [10] entries" is not there anymore.

I believe this is a much more logical option. Feel free to merge this PR if you want.

@gforge gforge merged commit dc166c5 into gforge:develop May 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gforge

This comment has been minimized.

Copy link
Owner

gforge commented May 22, 2017

Thanks!

@zeehio zeehio deleted the zeehio:fix_widget_single_num_entries branch Feb 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment