From a9c6904320cd71516fa1e3240b9e7c4c02083d9c Mon Sep 17 00:00:00 2001 From: Nicolas Berger Date: Thu, 10 Sep 2015 17:32:12 -0300 Subject: [PATCH] Use a form that throws in both clj & cljs Why would we use different forms if there are many forms that throw on both platforms? --- .../gfredericks/test/chuck/exception_handling_test.cljc | 7 +++---- test/com/gfredericks/test/chuck/properties_test.cljc | 5 ++--- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/test/com/gfredericks/test/chuck/exception_handling_test.cljc b/test/com/gfredericks/test/chuck/exception_handling_test.cljc index fab30a3..5d6b085 100644 --- a/test/com/gfredericks/test/chuck/exception_handling_test.cljc +++ b/test/com/gfredericks/test/chuck/exception_handling_test.cljc @@ -6,11 +6,10 @@ [com.gfredericks.test.chuck.clojure-test #?(:clj :refer :cljs :refer-macros) [checking]])) (deftest this-test-should-crash-and-be-caught - (checking "you can divide four by numbers" 100 [i gen/pos-int] + (checking "subs on any string or nil" 100 [s (gen/one-of [gen/string (gen/return nil)])] ;; going for uncaught-error-not-in-assertion here - (let [n #?(:clj (/ 4 i) - :cljs (throw (js/Error. "Oops!")))] - (is n)))) + (let [res (subs s 1 2)] + (is res)))) (defn capture-test-var [v] (with-out-str (test-var v))) diff --git a/test/com/gfredericks/test/chuck/properties_test.cljc b/test/com/gfredericks/test/chuck/properties_test.cljc index cedc3e0..8a1662c 100644 --- a/test/com/gfredericks/test/chuck/properties_test.cljc +++ b/test/com/gfredericks/test/chuck/properties_test.cljc @@ -16,9 +16,8 @@ :cljs js/Error) (:result (tc/quick-check 100 - (prop'/for-all [x gen/int] - #?(:clj (/ 4 0) - :cljs (throw (js/Error. "Oops"))))))))) + (prop'/for-all [s (gen/one-of [gen/string (gen/return nil)])] + (subs s 1 2))))))) (deftest reported-args-test (let [p (prop'/for-all [x gen/nat]