Skip to content

Fix build, bump deps, support times in cljs - #73

Merged
gfredericks merged 1 commit into
gfredericks:masterfrom
frenchy64:actions-build
Aug 14, 2021
Merged

Fix build, bump deps, support times in cljs#73
gfredericks merged 1 commit into
gfredericks:masterfrom
frenchy64:actions-build

Conversation

@frenchy64

Copy link
Copy Markdown
Contributor

Going out on a limb that this is a welcome change, but I saw the build has been broken for a while and PR's don't automatically run CI.

I took the opportunity to design a matrix build in Actions that uses times with different multipliers. Seems like a nice demo of its intended usage.

I noticed it's easy to support times in cljs too, so I added it.

@gfredericks

Copy link
Copy Markdown
Owner

oh man I had almost considered tweeting about this to see if anybody knew how to fix it

thanks!

@gfredericks
gfredericks merged commit 1245250 into gfredericks:master Aug 14, 2021
@gfredericks

Copy link
Copy Markdown
Owner

Released as 0.2.12

@frenchy64

Copy link
Copy Markdown
Contributor Author

Thanks!

@gfredericks

Copy link
Copy Markdown
Owner

(incidentally, the build is still failing, though in a different way than before; maybe there's a change I have to make on circleci?)

@frenchy64

Copy link
Copy Markdown
Contributor Author

@gfredericks

Copy link
Copy Markdown
Owner

oh, you switched it to...github actions?

@frenchy64

Copy link
Copy Markdown
Contributor Author

Shame on me for not making that more obvious, but yes! Happy to figure out how to build with CircleCI if that's a problem.

@gfredericks

Copy link
Copy Markdown
Owner

oh no it's fine -- I just assumed it was so radically different because circleci had made a bunch of changes

do I need a different badge in the README, or is the build status automatically displayed somewhere so I should just delete the circleci one?

@frenchy64

Copy link
Copy Markdown
Contributor Author

:) Yes, delete the CircleCI badge.

If you want a badge, see here, though it doesn't seem to add much to me.

@gfredericks

Copy link
Copy Markdown
Owner

Perfect, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants