Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try Kudzu instead of storage-map #2860

Open
kvark opened this issue Jun 24, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@kvark
Copy link
Member

commented Jun 24, 2019

See https://github.com/withoutboats/kudzu

Our storage-map was introduced simply because the existing solutions were lacking: https://github.com/kvark/storage-map

Our Metal performance depends on that structure. We should give Kudzu a try.

@kvark

This comment has been minimized.

Copy link
Member Author

commented Jun 27, 2019

Outline for completion:

  1. Check for the use of storage-map in our code, get familiar with its API
  2. See if it can be replaced with Kudzu, make a PR doing that

The most difficult piece here is benchmarking. Original storage-map was benched on Dota2 with gfx-portability. Setting up the portability is ideal, but not necessarily required. Once PR is done, we'll find a way to benchmark it and then follow up on the results. Also related to #2717

Feel free to ping me on GitHub or in our Gitter channel (https://gitter.im/gfx-rs/gfx) if you need help :)

@samsartor

This comment has been minimized.

Copy link

commented Jul 8, 2019

I think this may be blocked on kudzu#3 (e.g. metal/src/internal.rs line 205).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.