Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing typed command buffers, pools and queues #2862

Open
kvark opened this issue Jun 24, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@kvark
Copy link
Member

commented Jun 24, 2019

Anything on top of "raw" command types is not used by any backends, it's only for the user, and it doesn't help most important users either (rendy and wgpu-rs can't use those). So we should probably just remove those layers in favor of something like https://crates.io/crates/rendy-command
cc @omni-viral

@omni-viral

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

I can't neither support nor discourage this proposition.
For someone those wrappers could be good enough. And I don't think they add much maintenance cost.

... IIRC, there was UB somewhere.

@kvark

This comment has been minimized.

Copy link
Member Author

commented Jun 24, 2019

They have been actually requiring quite a bit of maintenance as we were reworking the raw model... Even today, I think compiler complains about some of the things we do in that typed layer and claims it to be deprecated, so there might be a point where it just stops to compile.

@kvark

This comment has been minimized.

Copy link
Member Author

commented Jun 26, 2019

Here are the steps for accomplishing the task:

  1. Get familiar with how the subject types in gfx-hal are represented by raw and typed layers:
    - CommandQueue
    - CommandBuffer
    - CommandPool
  2. Evaluate, to what extent is this functionality intersecting with rendy-command
  3. Communicate back to us, make a more detailed proposal of removing the redundancy
  4. Remove the respective types from gfx-hal
  5. Rename the remaining raw types to drop the "Raw" prefix
  6. Get huge thanks and kudos from the community :)
@zakorgy

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

@kvark it looks like we can transit to the raw types without any problem ( szeged/webrender#301 ), so we can give the green light for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.