Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upConsolidate the projects #768
Comments
This comment has been minimized.
This comment has been minimized.
ghost
commented
Jun 11, 2015
|
This is similar to how we started. I don't have a problem with this, but I want to preserve the commit history of all our projects. Not sure how to do with when merging git repos but there is bound to be a stackoverflow for it. |
This comment has been minimized.
This comment has been minimized.
|
@csherratt Good point. |
This comment has been minimized.
This comment has been minimized.
|
Not a @gfx-rs/developers but i think it sounds great! I didn't exactly have a good time making a PR for 5 separate gfx repos at the same time... |
This comment has been minimized.
This comment has been minimized.
|
@fkaa fixed! |
This comment has been minimized.
This comment has been minimized.
|
Small issue: |
This comment has been minimized.
This comment has been minimized.
|
Another issue: tests for dependent projects are not started automatically by |
kvark
self-assigned this
Jun 12, 2015
kvark
added
status: working
and removed
status: ready for work
labels
Jun 12, 2015
This comment has been minimized.
This comment has been minimized.
|
Don't have a problem with this, but I echo the comments about preserving git history. |
This comment has been minimized.
This comment has been minimized.
|
I wounder if this should be a medium or hard, given the difficulty of the repo merger. |
kvark
added
difficulty: average
and removed
difficulty: easy
labels
Jun 13, 2015
This comment has been minimized.
This comment has been minimized.
|
@bjz thanks for coming in! Since we use 'hard' for the most difficult issues (like, implement DX backend), this one deserves a vague I'll redo the PR with preserved history, not sure how painful it's going to be though. If you want to try it yourself, please give me a short nod so that we don't duplicate this exciting work. |
This comment has been minimized.
This comment has been minimized.
|
Heads up - SO answer seems to be working fine, I'm half-way through the change. |
This comment has been minimized.
This comment has been minimized.
ghost
commented
Jun 13, 2015
|
|
This comment has been minimized.
This comment has been minimized.
|
Nice! |
ghost
closed this
in
#770
Jun 14, 2015
kvark
removed
the
status: working
label
Jun 14, 2015
This comment has been minimized.
This comment has been minimized.
|
@bvssvni I was thinking if you would consider the unification of some degree for Piston repositories. Their diversity and number often seemed to be a source of confusion. |
kvark commentedJun 11, 2015
A bit of history:
gfx-rsstarted as a single project, having everything (renderer, device, macros, even windowing stuff) under one repository in different modulesCurrently we have 10 projects closely related to
gfx-rs, and this number doesn't includegfx_sceneorgenmesh. This confuses newcomers and throttles our ability to do cross-project changes.Unexpectedly, a new style of organization showed up to be effective in
gfx_sceneandclaymore: gather all relevant projects under one roof and use bothpath =andversion =in the dependencies. As it turned out, this scheme has proper crates dependencies and publishing doesn't require any temporary changes. I propose to follow this scheme forgfx-rsas well to get:cargo testdoes everything)gfx-rsorganization would have 4 projects instead of 13)Paint me red and stuff, but I don't see the downsides. Note that we can do it right now without breaking anything, since users now depend on
crates.io. Here is how I see the consolidated repo:Summoning @gfx-rs/developers for discussion!