Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[ll] dx12: Implement shader module creation from SPIR-V #1546
Conversation
msiglreith
requested a review
from kvark
Oct 5, 2017
| "vs_main", | ||
| "main", | ||
| include_bytes!("shader/quad.hlsl")) | ||
| .create_shader_module(include_bytes!("data/vert.spv")) |
This comment has been minimized.
This comment has been minimized.
kvark
Oct 5, 2017
Member
Can we switch the vulkan path to also get SPIRV for consistency, merging them here?
grovesNL
reviewed
Oct 5, 2017
src/backend/dx12/src/device.rs
Outdated
| @@ -761,10 +798,11 @@ impl d::Device<B> for Device { | |||
|
|
|||
| let shader_blob = Self::compile_shader( | |||
| stage, | |||
| compile_options.shader_model, | |||
| hlsl::ShaderModel::V5_1, | |||
This comment has been minimized.
This comment has been minimized.
msiglreith
force-pushed the
msiglreith:ll_spirv_dx12
branch
from
f07ec1d
to
ab93fa4
Oct 5, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks for the reviews! Addressed all points. |
bors bot
added a commit
that referenced
this pull request
Oct 5, 2017
kvark
reviewed
Oct 5, 2017
| @@ -114,35 +114,14 @@ fn main() { | |||
| let (mut swap_chain, backbuffers) = surface.build_swapchain(swap_config, &queue); | |||
|
|
|||
| // Setup renderpass and pipeline | |||
| // dx12 runtime shader compilation | |||
| #[cfg(feature = "dx12")] | |||
| #[cfg(any(feature = "vulkan", feature = "dx12"))] | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Timed out |
This comment has been minimized.
This comment has been minimized.
|
those lovely OSX CI timeouts... |
kvark
merged commit bdb0b2d
into
gfx-rs:ll
Oct 5, 2017
msiglreith
referenced this pull request
Oct 6, 2017
Closed
[ll] dx12: Shader module creation from SPIR-V #1538
kvark
referenced this pull request
Oct 17, 2017
Closed
[RFC][ll] SPIR-V as the shader API solution #1374
msiglreith
deleted the
msiglreith:ll_spirv_dx12
branch
Oct 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
msiglreith commentedOct 5, 2017
Implement shader module creation from SPIR-V binaries, including patching of descriptor sets for images and samplers (more patching needed for constant buffers, etc.) and invert y-axis to match Vulkan's coordinate system
Port quad example over to SPIR-V based shader modules
Use safer
clear_attachmentswrapper from ashI'm not totally happy with all the error handling in
create_shader_modulebut we don't know when SPIRV-Cross might throw an exception /: