Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbloat the build #2970

Merged
merged 3 commits into from Aug 22, 2019
Merged

Unbloat the build #2970

merged 3 commits into from Aug 22, 2019

Conversation

@kvark
Copy link
Member

kvark commented Aug 22, 2019

Removes dependency on failure and refactors our errors a bit.
This change reduces the gfx-hal build time from 45 sec to just 8 sec on my machine 馃帀

PR checklist:

  • make succeeds (on *nix)
  • make reftests succeeds
  • tested examples with the following backends: linux
  • rustfmt run on changed code
@kvark kvark requested a review from grovesNL Aug 22, 2019
@kvark kvark force-pushed the kvark:error branch from 8feed79 to a265ac9 Aug 22, 2019
@kvark kvark force-pushed the kvark:error branch from a265ac9 to 7a838c4 Aug 22, 2019
@kvark

This comment has been minimized.

Copy link
Member Author

kvark commented Aug 22, 2019

bors r=grovesNL

bors bot added a commit that referenced this pull request Aug 22, 2019
Merge #2970
2970: Unbloat the build r=grovesNL a=kvark

Removes dependency on failure and refactors our errors a bit.
This change reduces the gfx-hal build time from 45 sec to just 8 sec on my machine 馃帀 

PR checklist:
- [x] `make` succeeds (on *nix)
- [x] `make reftests` succeeds
- [x] tested examples with the following backends: linux
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Aug 22, 2019

@kvark kvark force-pushed the kvark:error branch from 7a838c4 to 9ea6554 Aug 22, 2019
@kvark

This comment has been minimized.

Copy link
Member Author

kvark commented Aug 22, 2019

bors r=grovesNL

bors bot added a commit that referenced this pull request Aug 22, 2019
Merge #2970
2970: Unbloat the build r=grovesNL a=kvark

Removes dependency on failure and refactors our errors a bit.
This change reduces the gfx-hal build time from 45 sec to just 8 sec on my machine 馃帀 

PR checklist:
- [x] `make` succeeds (on *nix)
- [x] `make reftests` succeeds
- [x] tested examples with the following backends: linux
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
@kvark kvark force-pushed the kvark:error branch from 9ea6554 to 80a5a43 Aug 22, 2019
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Aug 22, 2019

Canceled

@kvark

This comment has been minimized.

Copy link
Member Author

kvark commented Aug 22, 2019

bors r=grovesNL

bors bot added a commit that referenced this pull request Aug 22, 2019
Merge #2970
2970: Unbloat the build r=grovesNL a=kvark

Removes dependency on failure and refactors our errors a bit.
This change reduces the gfx-hal build time from 45 sec to just 8 sec on my machine 馃帀 

PR checklist:
- [x] `make` succeeds (on *nix)
- [x] `make reftests` succeeds
- [x] tested examples with the following backends: linux
- [ ] `rustfmt` run on changed code


Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Aug 22, 2019

@bors bors bot merged commit 80a5a43 into gfx-rs:master Aug 22, 2019
2 checks passed
2 checks passed
bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@matklad

This comment has been minimized.

Copy link

matklad commented Sep 1, 2019

do you know which part of the speed up is attributed to the removal of failure, and which to the other refactorings? I wonder if 鈥渞emoving failure may make your build five times faster鈥 is an accurate thing to say :)

@kvark

This comment has been minimized.

Copy link
Member Author

kvark commented Sep 1, 2019

@kvark kvark mentioned this pull request Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.