Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.6/dx12] descriptor freeing and recycling #3418

Merged
merged 2 commits into from Oct 19, 2020
Merged

[0.6/dx12] descriptor freeing and recycling #3418

merged 2 commits into from Oct 19, 2020

Conversation

kvark
Copy link
Member

@kvark kvark commented Oct 18, 2020

Should fix gfx-rs/wgpu#993
PR checklist:

  • make succeeds (on *nix)
  • make reftests succeeds
  • tested examples with the following backends:

@kvark kvark requested a review from msiglreith October 18, 2020 15:07
This was referenced Oct 18, 2020
Closed
Merged
msiglreith
msiglreith approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@msiglreith msiglreith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 19, 2020

Merge conflict.

bors bot added a commit that referenced this pull request Oct 19, 2020
@bors @kvark
Merge #3419
2f1ae6a 
3419: [dx12] implement descriptor freeing and recycling r=msiglreith a=kvark

Sibling of #3418 for master.

Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
@kvark
Copy link
Member Author

kvark commented Oct 19, 2020

bors r=msiglreith

@bors
Copy link
Contributor

bors bot commented Oct 19, 2020

Build succeeded:

@bors bors bot merged commit dbc1d03 into gfx-rs:hal-0.6 Oct 19, 2020
@kvark kvark deleted the 0.6-dx12-desc branch October 21, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msiglreith msiglreith msiglreith approved these changes

@monocodus monocodus[bot] monocodus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kvark @msiglreith