Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upMacros return! #725
Conversation
kvark
added some commits
May 9, 2015
kvark
added
the
status: working
label
May 10, 2015
kvark
changed the title
Macros return!
[WIP] Macros return!
May 10, 2015
kvark
changed the title
[WIP] Macros return!
Macros return!
May 10, 2015
This comment has been minimized.
This comment has been minimized.
ghost
commented
May 10, 2015
|
Looks good to me. I would like a 3rd to look over it. |
This comment has been minimized.
This comment has been minimized.
|
I'm impressed that the macro is almost as nice to use as the original syntax extension. LGTM. |
This comment has been minimized.
This comment has been minimized.
|
Looks good. I noticed the examples uses underscore in front for the shader parameter |
This comment has been minimized.
This comment has been minimized.
|
Thanks everyone! I'm merging then? @bvssvni about underscores. 1) they are in tests, not examples. and 2) they are not required, the variables are just unused, so I put an underscore. |
This comment has been minimized.
This comment has been minimized.
|
I've updated |
kvark
added a commit
that referenced
this pull request
May 10, 2015
kvark
merged commit 6957ff8
into
gfx-rs:master
May 10, 2015
1 check passed
kvark
removed
the
status: working
label
May 10, 2015
kvark
deleted the
kvark:stable
branch
May 10, 2015
This comment has been minimized.
This comment has been minimized.
|
Did no one really notice the X-Com reference with |
This comment has been minimized.
This comment has been minimized.
ghost
commented
May 10, 2015
|
I was wondering where you got the name from. Shamefully, I have never actually played xcom. |
kvark commentedMay 10, 2015
Closes #676
Examples: https://github.com/gfx-rs/gfx_examples/pull/23 (work on rust-beta)
Macros: gfx-rs/gfx_macros#18 (the bye-bye patch)
The change finalizes the port of gfx-rs to rust-beta. Users are advised to use the new macros syntax (check examples PR) and compile on rust beta/stable.
Notes
Practically deprecates
gfx_macros. I've lost a lot of blood writing these syntax extensions, but I'd better have a cleaner (and smaller) code base to deal with, so my vote is to letgfx_macrosrest in peace.Current problems (non-critical):
pubto all the generated structs and members, which prevents these to be declared inside functions_r: PhantomData<R>in each shader parameter structure