Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upVersion 0.6 #759
Conversation
csherratt
and others
added some commits
May 21, 2015
kvark
added
the
status: working
label
May 27, 2015
kvark
changed the title
Version 0.6
[WIP] Version 0.6
May 27, 2015
This comment has been minimized.
This comment has been minimized.
|
Hmm there is a problem... The parameter link we generate now in Edit: I have a temporary solution, need to pack the tuple better |
kvark
changed the title
[WIP] Version 0.6
Version 0.6
May 27, 2015
This comment has been minimized.
This comment has been minimized.
ghost
commented
May 27, 2015
|
LGTM. We will need to merge and publish in sequence. I can't publish it until this afternoon. |
kvark
changed the title
Version 0.6
[wip] Version 0.6
May 27, 2015
This comment has been minimized.
This comment has been minimized.
|
@csherratt I'd also like to provide |
This comment has been minimized.
This comment has been minimized.
LaylConway
commented
May 27, 2015
|
Why does Device create a factory rather than Factory creating more factories, since you get a factory at initialization? |
This comment has been minimized.
This comment has been minimized.
|
@LaylConway excellent point! Instead of We don't exactly have a factory at initialization though. There is |
This comment has been minimized.
This comment has been minimized.
|
@csherratt I think we are ready now. |
ghost
pushed a commit
that referenced
this pull request
May 28, 2015
ghost
merged commit 76a4770
into
gfx-rs:master
May 28, 2015
1 check passed
kvark
removed
the
status: working
label
May 28, 2015
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
|
kvark
deleted the
kvark:merge
branch
May 28, 2015
kvark
changed the title
[wip] Version 0.6
Version 0.6
May 28, 2015
This comment has been minimized.
This comment has been minimized.
|
|
kvark commentedMay 27, 2015
Closes #745
Has all the changes from 0.6 branch, merged with upstream.
GL device: https://github.com/gfx-rs/gfx_device_gl/pull/42
Glutin window: https://github.com/gfx-rs/gfx_window_glutin/pull/13
GLFW window: https://github.com/gfx-rs/gfx_window_glfw/pull/8
Examples: https://github.com/gfx-rs/gfx_examples/pull/30
Major changes:
batch::Coreorbatch::Full.Renderer::update_*calls now error out instead of panickinggfx_device_gl::FactoryimplementsCloneinstead ofgfx_device_gl::Device::spawn_factory