Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.6 #759

Merged
11 commits merged into from May 28, 2015

Conversation

@kvark
Copy link
Member

commented May 27, 2015

Closes #745
Has all the changes from 0.6 branch, merged with upstream.
GL device: https://github.com/gfx-rs/gfx_device_gl/pull/42
Glutin window: https://github.com/gfx-rs/gfx_window_glutin/pull/13
GLFW window: https://github.com/gfx-rs/gfx_window_glfw/pull/8
Examples: https://github.com/gfx-rs/gfx_examples/pull/30

Major changes:

  • now using crates.io internally for dependencies. Users are encouraged to also use it, we may not guarantee any stability in the Git tree.
  • batch context is removed as well as all the relevant batch types. Please use batch::Core or batch::Full.
  • texture kinds enum is totally changed
  • Renderer::update_* calls now error out instead of panicking
  • gfx_device_gl::Factory implements Clone instead of gfx_device_gl::Device::spawn_factory

@kvark kvark changed the title Version 0.6 [WIP] Version 0.6 May 27, 2015

@kvark

This comment has been minimized.

Copy link
Member Author

commented May 27, 2015

Hmm there is a problem... The parameter link we generate now in gfx_parameters! is a tuple. We want it to be clonable, but the Clone is only implemented for a limited tuple size, while our parameters may exceed it (and that actually happens in the deferred example)...

Edit: I have a temporary solution, need to pack the tuple better

@kvark kvark changed the title [WIP] Version 0.6 Version 0.6 May 27, 2015

@ghost ghost referenced this pull request May 27, 2015

Closed

Untested work around for tuple issue #760

@ghost

This comment has been minimized.

Copy link

commented May 27, 2015

LGTM. We will need to merge and publish in sequence. I can't publish it until this afternoon.

@kvark kvark changed the title Version 0.6 [wip] Version 0.6 May 27, 2015

@kvark

This comment has been minimized.

Copy link
Member Author

commented May 27, 2015

@csherratt I'd also like to provide Device::create_factory before merging. Wondering now if it's going to complicate any code... since Factory will need to be an associated type of the Device.

@LaylConway

This comment has been minimized.

Copy link

commented May 27, 2015

Why does Device create a factory rather than Factory creating more factories, since you get a factory at initialization?

@kvark

This comment has been minimized.

Copy link
Member Author

commented May 27, 2015

@LaylConway excellent point! Instead of create_factory we can just have Clone implemented by gfx_device_gl::Factory and the user code binding F: Factory<R> + Clone where needed.

We don't exactly have a factory at initialization though. There is gfx_device::gl::Device::new() that is called by gfx_window_* crates, and then the factory is created via create_factory. Changing it to cloning would require us to bring back gfx_device_gl::create() method as we had prior to 0.5.

@kvark

This comment has been minimized.

Copy link
Member Author

commented May 28, 2015

@csherratt I think we are ready now.

ghost pushed a commit that referenced this pull request May 28, 2015

@ghost ghost merged commit 76a4770 into gfx-rs:master May 28, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kvark kvark removed the status: working label May 28, 2015

@mitchmindtree

This comment has been minimized.

Copy link
Contributor

commented May 28, 2015

🎉 👏

@fkaa

This comment has been minimized.

Copy link
Member

commented May 28, 2015

🍰 🎊

@kvark kvark deleted the kvark:merge branch May 28, 2015

@kvark kvark changed the title [wip] Version 0.6 Version 0.6 May 28, 2015

@bvssvni

This comment has been minimized.

Copy link
Contributor

commented May 28, 2015

🎈

@kvark kvark referenced this pull request May 28, 2015

Closed

Cargo dependency policy #723

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.